From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYsdx-00074c-56 for qemu-devel@nongnu.org; Tue, 30 Sep 2014 04:18:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYsdq-0005pM-PG for qemu-devel@nongnu.org; Tue, 30 Sep 2014 04:18:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYsdq-0005oD-HS for qemu-devel@nongnu.org; Tue, 30 Sep 2014 04:18:38 -0400 Message-ID: <542A674C.8070501@redhat.com> Date: Tue, 30 Sep 2014 10:18:20 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411045577-1152-1-git-send-email-arei.gonglei@huawei.com> <542A57CE.9040000@redhat.com> <87wq8la5n1.fsf@blackfin.pond.sub.org> In-Reply-To: <87wq8la5n1.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: arei.gonglei@huawei.com, weidong.huang@huawei.com, qemu-devel@nongnu.org, mst@redhat.com Il 30/09/2014 10:12, Markus Armbruster ha scritto: > error_report() is just fine here. qerror_report() is never necessary in > HMP-only code. It makes a difference only in QMP context, and even > there it should only be used in code that hasn't been converted to the > Error API. For an example, see commit b1422f2. > > Eventually, qerror.h should just die. I've been chipping away at it > when I have nothing better to do. Slow progress, better than no > progress. > > Let's commit v4. Yeah, I've seen now that error_report ends up in monitor_vprintf. v4 is okay, sorry Gonglei. Paolo