From: Paolo Bonzini <pbonzini@redhat.com>
To: Zhi Yong Wu <zwu.kernel@gmail.com>, qemu-devel@nongnu.org
Cc: Zhi Yong Wu <zhiyong.wzy@alibaba-inc.com>
Subject: Re: [Qemu-devel] [PATCH v2] libcacard: fix compile error on glib2-2.12.3-4.el5
Date: Tue, 30 Sep 2014 11:28:22 +0200 [thread overview]
Message-ID: <542A77B6.5080306@redhat.com> (raw)
In-Reply-To: <1412068324-19981-1-git-send-email-zhiyong.wzy@alibaba-inc.com>
Il 30/09/2014 11:12, Zhi Yong Wu ha scritto:
> diff --git a/Makefile b/Makefile
> index b33aaac..7cbf7dd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -149,6 +149,8 @@ ifneq ($(wildcard config-host.mak),)
> include $(SRC_PATH)/tests/Makefile
> endif
> ifeq ($(CONFIG_SMARTCARD_NSS),y)
> +CFLAGS += -fPIC
> +LDFLAGS += $(LDFLAGS_SHARED)
> include $(SRC_PATH)/libcacard/Makefile
> endif
>
c++ ... -m64 -g -shared -o qemu-io qemu-io.o ...
So you are making all programs shared libraries? (And it would make no
sense even if you only made vscclient a shared library).
Can you include "make V=1" output in the commit message so that we
understand what is going on?
Paolo
next prev parent reply other threads:[~2014-09-30 9:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 9:12 [Qemu-devel] [PATCH v2] libcacard: fix compile error on glib2-2.12.3-4.el5 Zhi Yong Wu
2014-09-30 9:28 ` Paolo Bonzini [this message]
2014-09-30 13:57 ` Zhi Yong Wu
2014-09-30 14:06 ` Paolo Bonzini
2014-09-30 15:09 ` Zhi Yong Wu
2014-09-30 15:16 ` Paolo Bonzini
2014-09-30 15:26 ` Zhi Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542A77B6.5080306@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhiyong.wzy@alibaba-inc.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).