From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58060)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XYtqw-0007uK-HL
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 05:36:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XYtqn-0000Tp-II
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 05:36:14 -0400
Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:60002)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XYtqn-0000SV-Bh
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 05:36:05 -0400
Received: by mail-wi0-f174.google.com with SMTP id cc10so1911898wib.13
	for <qemu-devel@nongnu.org>; Tue, 30 Sep 2014 02:35:59 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <542A77B6.5080306@redhat.com>
Date: Tue, 30 Sep 2014 11:28:22 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1412068324-19981-1-git-send-email-zhiyong.wzy@alibaba-inc.com>
In-Reply-To: <1412068324-19981-1-git-send-email-zhiyong.wzy@alibaba-inc.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] libcacard: fix compile error on
	glib2-2.12.3-4.el5
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhi Yong Wu <zwu.kernel@gmail.com>, qemu-devel@nongnu.org
Cc: Zhi Yong Wu <zhiyong.wzy@alibaba-inc.com>

Il 30/09/2014 11:12, Zhi Yong Wu ha scritto:
> diff --git a/Makefile b/Makefile
> index b33aaac..7cbf7dd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -149,6 +149,8 @@ ifneq ($(wildcard config-host.mak),)
>  include $(SRC_PATH)/tests/Makefile
>  endif
>  ifeq ($(CONFIG_SMARTCARD_NSS),y)
> +CFLAGS += -fPIC
> +LDFLAGS += $(LDFLAGS_SHARED)
>  include $(SRC_PATH)/libcacard/Makefile
>  endif
>  

c++ ... -m64 -g  -shared -o qemu-io qemu-io.o ...

So you are making all programs shared libraries?  (And it would make no
sense even if you only made vscclient a shared library).

Can you include "make V=1" output in the commit message so that we
understand what is going on?

Paolo