From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYxbm-0005tm-6l for qemu-devel@nongnu.org; Tue, 30 Sep 2014 09:36:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYxbe-00059O-Ba for qemu-devel@nongnu.org; Tue, 30 Sep 2014 09:36:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYxbe-00058S-4Z for qemu-devel@nongnu.org; Tue, 30 Sep 2014 09:36:42 -0400 Message-ID: <542AB1D6.4010900@redhat.com> Date: Tue, 30 Sep 2014 15:36:22 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1412046159-5144-1-git-send-email-arei.gonglei@huawei.com> <1412046159-5144-2-git-send-email-arei.gonglei@huawei.com> <20140930114200.GF7089@redhat.com> <20140930133337.GC2999@redhat.com> In-Reply-To: <20140930133337.GC2999@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Gonglei Cc: weidong.huang@huawei.com, stefanha@redhat.com, qemu-devel@nongnu.org, luonengjun@huawei.com, armbru@redhat.com, peter.huangpeng@huawei.com, arei.gonglei@huawei.com, aliguori@amazon.com, lcapitulino@redhat.com, afaerber@suse.de Il 30/09/2014 15:33, Michael S. Tsirkin ha scritto: > > > > > The Propertyinfo.name is used to the qdev property's type, please see PATCH 4: > > > > - info->type = g_strdup(prop->info->legacy_name ?: prop->info->name); > > + info->type = g_strdup(prop->info->name); > > I would say this one is more a string than an int. At the QOM level it is an int, even though it secondarily accepts a string in "DD.F" format. Paolo