From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYzVf-00082J-FR for qemu-devel@nongnu.org; Tue, 30 Sep 2014 11:38:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYzVb-0006zL-0J for qemu-devel@nongnu.org; Tue, 30 Sep 2014 11:38:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYzVa-0006z6-On for qemu-devel@nongnu.org; Tue, 30 Sep 2014 11:38:34 -0400 Message-ID: <542ACE6E.2080900@redhat.com> Date: Tue, 30 Sep 2014 09:38:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1412046159-5144-1-git-send-email-arei.gonglei@huawei.com> <1412046159-5144-5-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1412046159-5144-5-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iXWeAs8PvjLgexEmgrJr2HjOuOrtRH8MX" Subject: Re: [Qemu-devel] [PATCH v4 4/5] qmp: print descriptions of object properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: weidong.huang@huawei.com, aliguori@amazon.com, mst@redhat.com, armbru@redhat.com, luonengjun@huawei.com, peter.huangpeng@huawei.com, lcapitulino@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iXWeAs8PvjLgexEmgrJr2HjOuOrtRH8MX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/29/2014 09:02 PM, arei.gonglei@huawei.com wrote: > From: Gonglei >=20 > Add a new "description" field to DevicePropertyInfo. > The descriptions can serve as documentation in the code, > and they can be used to provide better help. For example: >=20 > --- > qapi-schema.json | 4 +++- > qdev-monitor.c | 7 ++++++- > qmp.c | 13 ++++++++++--- > 3 files changed, 19 insertions(+), 5 deletions(-) >=20 Reviewed-by: Eric Blake (would be nice if qmp-commands.hx had an example for device-list-properties, but that can be a separate patch) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --iXWeAs8PvjLgexEmgrJr2HjOuOrtRH8MX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUKs5uAAoJEKeha0olJ0NqTNEIAIcTu5mNC5camJftAyMvOdkg vcwDSxFJoKOGwkDJu8dyJdzl7/Sn/+zvtYRBy2DsKc/3glmdauYsgXbxV3pg1ime 56hmgXgE6i/T0qTBTrgjO90KzhL065vdJfZRNn6jcxQzSMqfHzdSX228OVkETpDN TlL4s3TUx/QjikdzMc8Qt+zp6H8Y7Q5b9uc4EDIXHCOHjs33THuOwKrHHib/ReVx 1cEyOAKuy2gvHx2VjrgDD2Ux5eUn8p81wc7+/oE3Rsx83UkMX/qw66Mzt+ia3kIb Snxbl1WEF2AFQMSszq+DzyHsKrEzYQ4ZGpk4AN9Hf5JBsqtme3ZGQej4VlbQsQQ= =A0EH -----END PGP SIGNATURE----- --iXWeAs8PvjLgexEmgrJr2HjOuOrtRH8MX--