From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZ3p4-00041A-Gh for qemu-devel@nongnu.org; Tue, 30 Sep 2014 16:15:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZ3oz-0000Kn-IV for qemu-devel@nongnu.org; Tue, 30 Sep 2014 16:14:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZ3oz-0000Kb-8B for qemu-devel@nongnu.org; Tue, 30 Sep 2014 16:14:53 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8UKEpUC020335 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 30 Sep 2014 16:14:52 -0400 Message-ID: <542B0F3A.4040605@redhat.com> Date: Tue, 30 Sep 2014 14:14:50 -0600 From: Eric Blake MIME-Version: 1.0 References: <1412105489-7681-1-git-send-email-mreitz@redhat.com> <1412105489-7681-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1412105489-7681-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qOpOr0Hr7GMXjtludHkeV4hOgCruk001l" Subject: Re: [Qemu-devel] [PATCH 1/3] iotests: Use _img_info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qOpOr0Hr7GMXjtludHkeV4hOgCruk001l Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/30/2014 01:31 PM, Max Reitz wrote: > qemu-img info should only be used directly if the format-specific > information or the name of the format is relevant (some tests explicitl= y > test format-specific information; test 082 uses qcow2-specific settings= > to test the qemu-img interface); otherwise, tests should always use > _img_info instead. >=20 > Test 082 was touched only partially. It does test the qemu-img > interface; however, its invocations of qemu-img info are not real tests= > but rather verifications, so if format-specific information is not > important for the test, there is no reason not to use _img_info. In > contrast to directly invoking qemu-img info, "qcow2" is replaced by > "IMGFMT"; but as "qcow2" is only mentioned once in test 082 (in > _supported_fmt), I consider this an improvement. >=20 > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/070 | 2 +- > tests/qemu-iotests/070.out | 5 ++--- > tests/qemu-iotests/082 | 12 +++++----- > tests/qemu-iotests/082.out | 55 ++++++++++----------------------------= -------- > tests/qemu-iotests/095 | 4 ++-- > tests/qemu-iotests/095.out | 16 ++++---------- > 6 files changed, 26 insertions(+), 68 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qOpOr0Hr7GMXjtludHkeV4hOgCruk001l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUKw86AAoJEKeha0olJ0NqM+gH/2tmswjQ7JYdH57jscooR2qq 8LBv5Q5+Df6j79YXAst7ZYRRp4aQ91IAY/HZLaSVcxUX1EpdENRPVhwNduPuQiql 1yCdFYTcYWYTaVmW+Mw5dp05jCgGbkHpw+hlsOYHcjawR4R58MqeMxu8ZcXfOqk1 AJ5DZKU/88mbC3g+Z1Nzo0SlSpXa1ZQw5bul2q22pmivSmK8xFKuCldmPGK5ZGlW ve3r37AZ3GvpKsW3SdQ4AqFghrNbpQplLCH1pAqB+opTe3ESeedK4npxLuRITkb5 5d8gnTypsgaZTyopbTL1dDwpyPPAO84IteaS6+/A1oQQIbRwACoEYHgOQbPsQm8= =/0yV -----END PGP SIGNATURE----- --qOpOr0Hr7GMXjtludHkeV4hOgCruk001l--