From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZLSG-0004KV-D7 for qemu-devel@nongnu.org; Wed, 01 Oct 2014 11:04:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZLS8-0007EY-R1 for qemu-devel@nongnu.org; Wed, 01 Oct 2014 11:04:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48176 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZLS8-0007EQ-JV for qemu-devel@nongnu.org; Wed, 01 Oct 2014 11:04:28 -0400 Message-ID: <542C17FB.9070603@suse.de> Date: Wed, 01 Oct 2014 17:04:27 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1411722458-21569-1-git-send-email-bharata@linux.vnet.ibm.com> In-Reply-To: <1411722458-21569-1-git-send-email-bharata@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v0 0/2] target-ppc: Fix an invalid free List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao , qemu-devel@nongnu.org On 26.09.14 11:07, Bharata B Rao wrote: > g_free() in target-ppc/translate_init.c:ppc_cpu_unrealizefn() can fail > due to invalid pointer being passed to it. Fix this along with a cleanup. > > I have never seen ppc_cpu_unrealizefn() getting called for sPAPR guests, > but I ran into this issue when I was adding unrealize call from the CPU > hot removal path while working on CPU [un]hotplug support for sPAPR guests. This opcode table handling code really is pretty ugly code :). Thanks, applied both to ppc-next. Alex