[Qemu-devel] pending target-mips patches

[Qemu-devel] pending target-mips patches

[Leon Alrae]

Hi All,

I noticed that it's quite difficult to get target-mips changes
reviewed/accepted. There is already a queue of relatively big features
and bug fixes which are stuck for months. Does anyone have an idea how
to improve this situation? Wouldn't it help to have a target-mips
co-maintainer assisting Aurelien?

Leon

Re: [Qemu-devel] pending target-mips patches

[Peter Maydell]

On 1 October 2014 16:35, Leon Alrae <leon.alrae@imgtec.com> wrote:
> I noticed that it's quite difficult to get target-mips changes
> reviewed/accepted. There is already a queue of relatively big features
> and bug fixes which are stuck for months. Does anyone have an idea how
> to improve this situation? Wouldn't it help to have a target-mips
> co-maintainer assisting Aurelien?

I agree that an active co-maintainer for target-mips would
be a good idea. Is anybody volunteering? (Are you? :-))

If somebody wants to take on this job, a good first start
would be to assemble a git tree of patches which have got
code review (ie which have accumulated at least one
reviewed-by tag and aren't the subject of on-list
disagreement about whether they're correct), test it, and
submit it as a pull request (in the right format, and with
your signed-off-by lines on the patches and any reviewed-by
or acked-by lines from the list)... If somebody does that
I will take a look at the result and if I'm happy with it
I'll apply them.

thanks
-- PMM

Re: [Qemu-devel] pending target-mips patches

[Leon Alrae]

Hi Peter,

On 01/10/2014 17:32, Peter Maydell wrote:
> On 1 October 2014 16:35, Leon Alrae <leon.alrae@imgtec.com> wrote:
>> I noticed that it's quite difficult to get target-mips changes
>> reviewed/accepted. There is already a queue of relatively big features
>> and bug fixes which are stuck for months. Does anyone have an idea how
>> to improve this situation? Wouldn't it help to have a target-mips
>> co-maintainer assisting Aurelien?
> 
> I agree that an active co-maintainer for target-mips would
> be a good idea. Is anybody volunteering? (Are you? :-))

I would be happy to help maintaining target-mips, but I'm wondering if
there are any more experienced (especially in legacy MIPS) volunteers.

> If somebody wants to take on this job, a good first start
> would be to assemble a git tree of patches which have got
> code review (ie which have accumulated at least one
> reviewed-by tag and aren't the subject of on-list
> disagreement about whether they're correct), test it, and
> submit it as a pull request (in the right format, and with
> your signed-off-by lines on the patches and any reviewed-by
> or acked-by lines from the list)... If somebody does that
> I will take a look at the result and if I'm happy with it
> I'll apply them.

Sounds straightforward, thanks.

Regards,
Leon

Re: [Qemu-devel] pending target-mips patches

[Andreas Färber]

[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]

Hi Leon,

Am 01.10.2014 um 17:35 schrieb Leon Alrae:
> I noticed that it's quite difficult to get target-mips changes
> reviewed/accepted. There is already a queue of relatively big features
> and bug fixes which are stuck for months. Does anyone have an idea how
> to improve this situation? Wouldn't it help to have a target-mips
> co-maintainer assisting Aurelien?

In February I talked to one of your directors and suggested whether
someone from Imagination could step up as co-maintainer to tackle this.
I admit, we never followed up on that conversation so far...

So, from my view what someone should do by now is this:

* Set up one or more public Git branches for officially queuing
target-mips/ and hw/mips/ patches. That helps track pending patches and
facilitates testing. I assume you have some shared internal tree anyway,
just split between what that maintainer considers good and what is still
work-in-progress.

* From time to time, send a PULL request that either Aurélien or Peter
can merge. Aurélien used to commit patches himself traditionally,
whereas I am suggesting to adopt the workflow used for ARM and Power.

The underlying assumption is that such MIPS patches would not touch
generic code without explicit ACKs, thereby not breaking x86 code.

Also, as usual, the person needs to have been around qemu-devel a little
and beware of what common style/functional issues to look out for and of
what legacy machines/CPUs exist that might break when implementing new
stuff - having test images to verify would be ideal.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [Qemu-devel] pending target-mips patches

[Aurelien Jarno]

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

Hi,

On Wed, Oct 01, 2014 at 04:35:46PM +0100, Leon Alrae wrote:
> Hi All,
> 
> I noticed that it's quite difficult to get target-mips changes
> reviewed/accepted. There is already a queue of relatively big features
> and bug fixes which are stuck for months. Does anyone have an idea how
> to improve this situation? Wouldn't it help to have a target-mips
> co-maintainer assisting Aurelien?

I am sorry but I don't really have time to work on QEMU now, though I
hope to be able to contribute again in the next months. Adding a
co-maintainer for target-mips indeed looks the best to do. From what
I have seen, you, Leon Alrae, seems to be the good person for that.

Please send a patch updating the MAINTAINERS file with you name, I'll
ack it. 

Cheers,
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: [Qemu-devel] pending target-mips patches

[Leon Alrae]

On 16/10/2014 11:12, Aurelien Jarno wrote:
> Hi,
> 
> On Wed, Oct 01, 2014 at 04:35:46PM +0100, Leon Alrae wrote:
>> Hi All,
>>
>> I noticed that it's quite difficult to get target-mips changes
>> reviewed/accepted. There is already a queue of relatively big features
>> and bug fixes which are stuck for months. Does anyone have an idea how
>> to improve this situation? Wouldn't it help to have a target-mips
>> co-maintainer assisting Aurelien?
> 
> I am sorry but I don't really have time to work on QEMU now, though I
> hope to be able to contribute again in the next months. Adding a
> co-maintainer for target-mips indeed looks the best to do. From what
> I have seen, you, Leon Alrae, seems to be the good person for that.
> 
> Please send a patch updating the MAINTAINERS file with you name, I'll
> ack it. 
> 
> Cheers,
> Aurelien
> 

Thanks Aurelien. I'll send the patch shortly.

Regards,
Leon