From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53618)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XZOTn-0003Lr-Em
	for qemu-devel@nongnu.org; Wed, 01 Oct 2014 14:18:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XZOTe-0003Yk-DN
	for qemu-devel@nongnu.org; Wed, 01 Oct 2014 14:18:23 -0400
Received: from mail-wg0-x22f.google.com ([2a00:1450:400c:c00::22f]:53927)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XZOTe-0003YQ-6a
	for qemu-devel@nongnu.org; Wed, 01 Oct 2014 14:18:14 -0400
Received: by mail-wg0-f47.google.com with SMTP id x13so1218835wgg.30
	for <qemu-devel@nongnu.org>; Wed, 01 Oct 2014 11:18:13 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <542C4565.9090706@redhat.com>
Date: Wed, 01 Oct 2014 20:18:13 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1412101566-23669-1-git-send-email-ehabkost@redhat.com>	<1412101566-23669-5-git-send-email-ehabkost@redhat.com>	<542B2CA2.5030900@redhat.com>
	<20141001162822.GG3113@thinpad.lan.raisama.net>
In-Reply-To: <20141001162822.GG3113@thinpad.lan.raisama.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 4/7] tests: Add unit test for X86CPU code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org, =?windows-1252?Q?Andreas_F=E4rber?= <afaerber@suse.de>

Il 01/10/2014 18:28, Eduardo Habkost ha scritto:
>> > tests/x86-stub.c perhaps can be moved to target-i386/test-stubs.c?
> I was trying to keep all test code inside tests/. But perhaps all the
> target-specific test code (including test-x86-cpu.c) could be moved to
> target directories, and we could build/run the target-specific test
> cases from Makefile.target. That should simplify some of the logic I
> have added, and fix the build dependency problem I mentioned in the
> patch description.

In the end that's just bikeshedding.  Sooner or later we'll have to
organize tests/ in subdirectories, but it's probably early enough that
we may not care yet.  tests/x86-stub.c be it.

Paolo