From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56138)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XZOce-0003i6-Aa
	for qemu-devel@nongnu.org; Wed, 01 Oct 2014 14:27:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XZOcY-0006go-2j
	for qemu-devel@nongnu.org; Wed, 01 Oct 2014 14:27:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15099)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XZOcX-0006fe-RZ
	for qemu-devel@nongnu.org; Wed, 01 Oct 2014 14:27:26 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s91IRNGs016616
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 1 Oct 2014 14:27:24 -0400
Message-ID: <542C4787.2000207@redhat.com>
Date: Wed, 01 Oct 2014 20:27:19 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1412182919-9550-1-git-send-email-stefanha@redhat.com>
	<1412182919-9550-2-git-send-email-stefanha@redhat.com>
In-Reply-To: <1412182919-9550-2-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/11] block: acquire AioContext in generic
 blockjob QMP commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>

On 01.10.2014 19:01, Stefan Hajnoczi wrote:
> block-job-set-speed, block-job-cancel, block-job-pause,
> block-job-resume, and block-job-complete must acquire the
> BlockDriverState AioContext so that it is safe to access bs.
>
> At the moment bs->job is always NULL when dataplane is active because op
> blockers prevent blockjobs from starting.  Once the rest of the blockjob
> API has been made aware of AioContext we can drop the op blocker.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   blockdev.c | 52 +++++++++++++++++++++++++++++++++++++++-------------
>   1 file changed, 39 insertions(+), 13 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>