From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZiF9-0005Rv-RA for qemu-devel@nongnu.org; Thu, 02 Oct 2014 11:24:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZiF4-0007BP-F0 for qemu-devel@nongnu.org; Thu, 02 Oct 2014 11:24:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50043) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZiF4-0007Al-8E for qemu-devel@nongnu.org; Thu, 02 Oct 2014 11:24:30 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s92FORvr031514 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 2 Oct 2014 11:24:28 -0400 Message-ID: <542D6E2A.6070301@redhat.com> Date: Thu, 02 Oct 2014 09:24:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1412261496-24455-1-git-send-email-armbru@redhat.com> <1412261496-24455-3-git-send-email-armbru@redhat.com> In-Reply-To: <1412261496-24455-3-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kfCEaMMfgxMKff10HOg4vlLiGwPSwWhLK" Subject: Re: [Qemu-devel] [PATCH 2/6] blockdev-test: Use single rather than double quotes in QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kfCEaMMfgxMKff10HOg4vlLiGwPSwWhLK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/02/2014 08:51 AM, Markus Armbruster wrote: > QMP accepts both single and double quotes. This is the only test > using double quotes. They need to be quoted in C strings. Replace > them by single quotes. Ooh, the use of single quotes on input is undocumented, and a violation of JSON. We always output double quotes, and I've been relying on =2Ejson/.hx files using single quotes for QAPI vs. double quotes for QMP examples. What would break if we tightened up our input parser to forbid non-JSON inputs and mandate that QMP use double quotes, bringing us into compliance with our docs (docs/qmp/README)? >=20 > Signed-off-by: Markus Armbruster > --- > tests/drive_del-test.c | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) If we WANT to keep undocumented support for single quotes (and/or document our extension to JSON), then this is fine; otherwise, I'd prefer that we use double quotes in QMP. But if we decide single quotes are tolerable, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kfCEaMMfgxMKff10HOg4vlLiGwPSwWhLK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJULW4qAAoJEKeha0olJ0NqHPYH/0Jbvs2l+g59cfPQt0yvq3+z WE5Q5O1kosh+N3s5GlI3IwfMS4VPRKQXKkH977KYi7YSJJ44J286EXXbX6rF7CPW +j1hfSHiwwnodU4w8pubEsZ7T8wValPLLZQLWSU6ng1M/qhjv7ncDpEks4BqT+x8 hNrir7gT09Fmrb0Zit04MTDGVEYpSp9qsIKBECmDsCyQp7IakVL4FZpXU7XAqkyE k8HRxVF/ZuxDiCljOERTk8w3LoAyogob41MvkJ9d1xCaLrxQja+LBjia0JEZO86h LJpprYYMMRjmTsomNUwTd/k16dDGRsHbMByNaRZKMdaAfW/JVP/EDDnko0Jnmu8= =WTo3 -----END PGP SIGNATURE----- --kfCEaMMfgxMKff10HOg4vlLiGwPSwWhLK--