From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/6] drive_del-test: Merge of qdev-monitor-test, blockdev-test
Date: Thu, 02 Oct 2014 09:26:48 -0600 [thread overview]
Message-ID: <542D6EB8.80500@redhat.com> (raw)
In-Reply-To: <1412261496-24455-2-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
On 10/02/2014 08:51 AM, Markus Armbruster wrote:
> Each of qdev-monitor-test and blockdev-test has just one test case,
> and both are about drive_del.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/Makefile | 5 +--
> tests/blockdev-test.c | 59 -------------------------
> tests/{qdev-monitor-test.c => drive_del-test.c} | 57 +++++++++++++++++++-----
> 3 files changed, 47 insertions(+), 74 deletions(-)
> delete mode 100644 tests/blockdev-test.c
> rename tests/{qdev-monitor-test.c => drive_del-test.c} (56%)
Reviewed-by: Eric Blake <eblake@redhat.com>
> --- a/tests/qdev-monitor-test.c
> +++ b/tests/drive_del-test.c
> @@ -1,5 +1,5 @@
> /*
> - * qdev-monitor.c test cases
> + * blockdev.c test cases
> *
> * Copyright (C) 2013 Red Hat Inc.
Worth bumping this to include 2014 while at it?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-10-02 15:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 14:51 [Qemu-devel] [PATCH 0/6] Improve drive_del test coverage Markus Armbruster
2014-10-02 14:51 ` [Qemu-devel] [PATCH 1/6] drive_del-test: Merge of qdev-monitor-test, blockdev-test Markus Armbruster
2014-10-02 15:26 ` Eric Blake [this message]
2014-10-02 16:20 ` Markus Armbruster
2014-10-02 14:51 ` [Qemu-devel] [PATCH 2/6] blockdev-test: Use single rather than double quotes in QMP Markus Armbruster
2014-10-02 15:24 ` Eric Blake
2014-10-02 16:24 ` Markus Armbruster
2014-10-02 14:51 ` [Qemu-devel] [PATCH 3/6] blockdev-test: Clean up bogus drive_add argument Markus Armbruster
2014-10-02 15:27 ` Eric Blake
2014-10-02 14:51 ` [Qemu-devel] [PATCH 4/6] blockdev-test: Simplify by using g_assert_cmpstr() Markus Armbruster
2014-10-02 15:31 ` Eric Blake
2014-10-02 14:51 ` [Qemu-devel] [PATCH 5/6] blockdev-test: Factor out some common code into helpers Markus Armbruster
2014-10-02 15:35 ` Eric Blake
2014-10-02 14:51 ` [Qemu-devel] [PATCH 6/6] blockdev-test: Test device_del after drive_del Markus Armbruster
2014-10-02 15:38 ` Eric Blake
2014-10-02 16:25 ` Markus Armbruster
2014-10-04 18:35 ` [Qemu-devel] [PATCH 0/6] Improve drive_del test coverage Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542D6EB8.80500@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).