From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZiSt-0006rs-Qd for qemu-devel@nongnu.org; Thu, 02 Oct 2014 11:38:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZiSo-0003ms-SH for qemu-devel@nongnu.org; Thu, 02 Oct 2014 11:38:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZiSo-0003mk-JV for qemu-devel@nongnu.org; Thu, 02 Oct 2014 11:38:42 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s92FcfMw012598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 2 Oct 2014 11:38:42 -0400 Message-ID: <542D7181.8060408@redhat.com> Date: Thu, 02 Oct 2014 09:38:41 -0600 From: Eric Blake MIME-Version: 1.0 References: <1412261496-24455-1-git-send-email-armbru@redhat.com> <1412261496-24455-7-git-send-email-armbru@redhat.com> In-Reply-To: <1412261496-24455-7-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lrtT313QfGecVElCkcSjrfrs5MeSgLXQD" Subject: Re: [Qemu-devel] [PATCH 6/6] blockdev-test: Test device_del after drive_del List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lrtT313QfGecVElCkcSjrfrs5MeSgLXQD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/02/2014 08:51 AM, Markus Armbruster wrote: > Executed in this order, drive_del and device_del's automatic drive > deletion take notoriously tricky special paths. >=20 > Signed-off-by: Markus Armbruster > --- > tests/drive_del-test.c | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) >=20 > diff --git a/tests/drive_del-test.c b/tests/drive_del-test.c > + /* Complication: ignore DEVICE_DELETED event */ > + qmp_discard_response("{'execute': 'device_del'," Still not a fan of single quotes in QMP, but it's existing style. > +static void test_drive_del_device_del(void) > +{ > + /* Start with a drive used by an device that unplugs instantaneous= ly */ s/an device/a device/ New tests are always good; with the typo fix: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lrtT313QfGecVElCkcSjrfrs5MeSgLXQD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJULXGBAAoJEKeha0olJ0NqQFEH/iSQNnDOJ4dsH2A9DSKENNRl nEAmQXuwnr1b1EaCQmybWyLh1bumDjElWf2MPFdspCXxwaTtKwyIR2Od/MJIid5R 4qtI+TpnCWLCQ1LNUP4jOLMEvLh4kzhL+vzhqo5XY3el3mo1unMm0EYf2nMC8Cdp pdCumNXLfZyJq3VEAobAZsI/vCT6xb5wyBNWXqozFTaKv5phQk7VKHMhgkftQ6wf e5114DcPqL+3JgH061rJjSx6HwZcciyx91Kkj0pelFYyDVjgbeOzMeOi5qAAgX+p ds2ig1KSxVzyJeKKQwLQG66r56N2dcpKBT6BDa4BqduGlMCMZgnL3304mOV63Bo= =WTWQ -----END PGP SIGNATURE----- --lrtT313QfGecVElCkcSjrfrs5MeSgLXQD--