From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46172)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XaBFL-0002gn-TV
	for qemu-devel@nongnu.org; Fri, 03 Oct 2014 18:22:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XaBFG-0004B5-Kt
	for qemu-devel@nongnu.org; Fri, 03 Oct 2014 18:22:43 -0400
Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:56884)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XaBFG-0004Ax-Dw
	for qemu-devel@nongnu.org; Fri, 03 Oct 2014 18:22:38 -0400
Received: by mail-wi0-f179.google.com with SMTP id d1so115667wiv.12
	for <qemu-devel@nongnu.org>; Fri, 03 Oct 2014 15:22:37 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <542F21A9.2050001@redhat.com>
Date: Sat, 04 Oct 2014 00:22:33 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1412266658-25643-1-git-send-email-minyard@acm.org>
	<1412266658-25643-6-git-send-email-minyard@acm.org>
In-Reply-To: <1412266658-25643-6-git-send-email-minyard@acm.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client
	sockets
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: minyard@acm.org, qemu-devel@nongnu.org
Cc: mjg59@srcf.ucam.org, mst@redhat.com, hwd@huawei.com, bcketchum@gmail.com, Corey Minyard <cminyard@mvista.com>, afaerber@suse.de

Il 02/10/2014 18:17, minyard@acm.org ha scritto:
> +    if (!qemu_chr_open_socket_fd(chr, &err)) {
> +        error_report("Unable to connect to char device %s\n", chr->label);
> +        qemu_chr_socket_restart_timer(chr);
> +    }

Can you please add a follow-up patch that only prints this message once
per reconnect?  Otherwise a server that shuts down can spam logs forever.

I'll nevertheless queue the patches for 2.2 next week.

Thanks,

Paolo