From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XaRfi-0002cc-E4 for qemu-devel@nongnu.org; Sat, 04 Oct 2014 11:55:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XaRfZ-0007SD-Es for qemu-devel@nongnu.org; Sat, 04 Oct 2014 11:55:02 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:37826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XaRfY-0007S2-B0 for qemu-devel@nongnu.org; Sat, 04 Oct 2014 11:54:52 -0400 Received: by mail-wi0-f180.google.com with SMTP id em10so1241546wid.7 for ; Sat, 04 Oct 2014 08:54:51 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <54301843.3070900@redhat.com> Date: Sat, 04 Oct 2014 17:54:43 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1412266658-25643-1-git-send-email-minyard@acm.org> <1412266658-25643-6-git-send-email-minyard@acm.org> <542F21A9.2050001@redhat.com> <542F6867.8090304@mvista.com> In-Reply-To: <542F6867.8090304@mvista.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Minyard , minyard@acm.org, qemu-devel@nongnu.org Cc: bcketchum@gmail.com, mjg59@srcf.ucam.org, hwd@huawei.com, afaerber@suse.de, mst@redhat.com Il 04/10/2014 05:24, Corey Minyard ha scritto: >> > Can you please add a follow-up patch that only prints this message once >> > per reconnect? Otherwise a server that shuts down can spam logs forever. > Yes, not a problem. I always wonder the best way to handle something > like that, but you are probably right. We can add QMP events for chardev open/closed/failed to connect, similar to what is already there for VNC. stdout/stderr is not a management interface, so it's better to keep it minimal. Paolo