From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XaSPs-0000NW-Vd for qemu-devel@nongnu.org; Sat, 04 Oct 2014 12:42:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XaSPh-00063H-1O for qemu-devel@nongnu.org; Sat, 04 Oct 2014 12:42:44 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:43997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XaSPg-000637-QV for qemu-devel@nongnu.org; Sat, 04 Oct 2014 12:42:32 -0400 Received: by mail-wi0-f176.google.com with SMTP id hi2so1303102wib.3 for ; Sat, 04 Oct 2014 09:42:31 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <54302372.2050300@redhat.com> Date: Sat, 04 Oct 2014 18:42:26 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-33-git-send-email-dgilbert@redhat.com> In-Reply-To: <1412358473-31398-33-git-send-email-dgilbert@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 32/47] postcopy: ram_enable_notify to switch on userfault List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, amit.shah@redhat.com, yanghy@cn.fujitsu.com Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > +static int postcopy_ram_sensitise_area(const char *block_name, void *host_addr, > + ram_addr_t offset, ram_addr_t length, > + void *opaque) Weird name, and I'm not referring to the British -ise. :) Perhaps ram_block_enable_userfault or ram_block_enable_notify? It helps clarity to limit the use of the "postcopy_ram_" prefix for static function. Paolo