From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XaTT7-000332-9H for qemu-devel@nongnu.org; Sat, 04 Oct 2014 13:50:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XaTSy-00018P-9f for qemu-devel@nongnu.org; Sat, 04 Oct 2014 13:50:09 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:53706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XaTSy-00018L-2z for qemu-devel@nongnu.org; Sat, 04 Oct 2014 13:50:00 -0400 Received: by mail-wi0-f173.google.com with SMTP id fb4so1391656wid.0 for ; Sat, 04 Oct 2014 10:49:59 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <54303323.1010703@redhat.com> Date: Sat, 04 Oct 2014 19:49:23 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-48-git-send-email-dgilbert@redhat.com> In-Reply-To: <1412358473-31398-48-git-send-email-dgilbert@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 47/47] End of migration for postcopy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, amit.shah@redhat.com, yanghy@cn.fujitsu.com Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > + mis->postcopy_ram_state); > + if (mis->postcopy_ram_state == POSTCOPY_RAM_INCOMING_ADVISE) { > + /* > + * Where a migration had postcopy enabled (and thus went to advise) > + * but managed to complete within the precopy period > + */ > + postcopy_ram_incoming_cleanup(mis); > + } else { > + if ((ret >= 0) && > + (mis->postcopy_ram_state > POSTCOPY_RAM_INCOMING_ADVISE)) { > + /* > + * Postcopy was started, cleanup should happen at the end of the > + * postcopy thread. > + */ > + DPRINTF("process_incoming_migration_co: exiting main branch"); > + return; > + } Extra parentheses and extra nesting. Paolo