From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XaTko-00009j-5S for qemu-devel@nongnu.org; Sat, 04 Oct 2014 14:08:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XaTkf-0006pR-4i for qemu-devel@nongnu.org; Sat, 04 Oct 2014 14:08:26 -0400 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:53013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XaTke-0006nf-Ue for qemu-devel@nongnu.org; Sat, 04 Oct 2014 14:08:17 -0400 Received: by mail-wg0-f42.google.com with SMTP id z12so3679965wgg.13 for ; Sat, 04 Oct 2014 11:08:16 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5430378A.5030604@redhat.com> Date: Sat, 04 Oct 2014 20:08:10 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-15-git-send-email-dgilbert@redhat.com> In-Reply-To: <1412358473-31398-15-git-send-email-dgilbert@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 14/47] Return path: Control commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, amit.shah@redhat.com, yanghy@cn.fujitsu.com Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > QEMU_VM_CMD_INVALID = 0, /* Must be 0 */ > + QEMU_VM_CMD_OPENRP, /* Tell the dest to open the Return path */ OPEN_RETURN_PATH? > + QEMU_VM_CMD_REQACK, /* Request an ACK on the RP */ SEND_ACK or ACK_REQUESTED? > QEMU_VM_CMD_AFTERLASTVALID Pleaseseparatewords. Is this enum actually used at all? Please avoid the difference between QEMU_VM_CMD and MIG_RPCOMM_. Perhaps MIG_CMD and MIG_RPCMD_? Paolo