From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54517)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XaWFZ-00048g-UQ
	for qemu-devel@nongnu.org; Sat, 04 Oct 2014 16:48:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XaWFT-0003Ko-P9
	for qemu-devel@nongnu.org; Sat, 04 Oct 2014 16:48:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30745)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XaWFT-0003JR-HO
	for qemu-devel@nongnu.org; Sat, 04 Oct 2014 16:48:15 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s94KmEl3014552
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Sat, 4 Oct 2014 16:48:14 -0400
Message-ID: <54305D0A.4060400@redhat.com>
Date: Sat, 04 Oct 2014 22:48:10 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1412182919-9550-1-git-send-email-stefanha@redhat.com>
	<1412182919-9550-9-git-send-email-stefanha@redhat.com>
In-Reply-To: <1412182919-9550-9-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 08/11] block: let stream blockjob run in
	BDS AioContext
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>

On 01.10.2014 19:01, Stefan Hajnoczi wrote:
> The stream block job must run in the BlockDriverState AioContext so that
> it works with dataplane.
>
> The basics of acquiring the AioContext are easy in blockdev.c.
>
> The tricky part is the completion code which drops part of the backing
> file chain.  This must be done in the main loop where bdrv_unref() and
> bdrv_close() are safe to call.  Use block_job_defer_to_main_loop() to
> achieve that.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   block/stream.c | 50 ++++++++++++++++++++++++++++++++++++--------------
>   blockdev.c     | 16 ++++++++++++----
>   2 files changed, 48 insertions(+), 18 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>