From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbF1P-0001UU-PK for qemu-devel@nongnu.org; Mon, 06 Oct 2014 16:36:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XbF1E-00057c-Fe for qemu-devel@nongnu.org; Mon, 06 Oct 2014 16:36:43 -0400 Received: from mail-wg0-x229.google.com ([2a00:1450:400c:c00::229]:55719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbF1E-00057L-67 for qemu-devel@nongnu.org; Mon, 06 Oct 2014 16:36:32 -0400 Received: by mail-wg0-f41.google.com with SMTP id b13so7557916wgh.0 for ; Mon, 06 Oct 2014 13:36:31 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5432FD48.6020002@redhat.com> Date: Mon, 06 Oct 2014 22:36:24 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1412618363-14968-1-git-send-email-minyard@acm.org> <1412618363-14968-2-git-send-email-minyard@acm.org> <5432E14A.8030105@redhat.com> In-Reply-To: <5432E14A.8030105@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-char: Fix reconnect socket error reporting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , minyard@acm.org, qemu-devel@nongnu.org Cc: Corey Minyard -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 06/10/2014 20:36, Eric Blake ha scritto: >>> - qemu_chr_socket_restart_timer(chr); + >>> check_report_connect_error(chr, "Unable to connect to"); > Works in English, but if there is ever translation of the message > printed in check_report_connect_error, you are probably doing > translators a disservice by splitting a sentence into two parts > separated by a number of lines of code. (Spoken by one who has > never contributed a translation, so take with a grain of salt) > I agree, I think it's simpler to unify the two messages. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUMv1IAAoJEBRUblpOawnXtFoH/1QIYr/yZXZQhw7zqDxiyhgH Gto3UiDjd/eLNC/iFwdY3J2pnuHIu8yVmBAO68cALdK6KotZ6X/TGVpsGUmPeoPk rPtkbxAvBvxdPImCUi798YSXbkOsVA/5+pMOOxNLeMwzA2ClFDFBqzgqgBbL/PwU O25XgCNucwFpk6An5yTOblHbS5Ji6oSnfJfHkXwuZlzjE7ql2nbr0Gr9lEulgHk3 3+hDoyesCD55V0r1qO/CwGJsuyJ1PXJGxV65ML1ja6F+yiMjlCgaTmzLAtcdWu4A oD6wR5auS9ZTWogS/JBxCx9oFnZVs19LgnSPSvQVHb3TaQJcVSTZuQjkb3/m8bU= =ctwR -----END PGP SIGNATURE-----