From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48253)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Xbqn8-0003I8-5a
	for qemu-devel@nongnu.org; Wed, 08 Oct 2014 08:56:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Xbqn3-0002lT-EN
	for qemu-devel@nongnu.org; Wed, 08 Oct 2014 08:56:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52881)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Xbqn3-0002kY-7m
	for qemu-devel@nongnu.org; Wed, 08 Oct 2014 08:56:25 -0400
Message-ID: <54353474.2070503@redhat.com>
Date: Wed, 08 Oct 2014 14:56:20 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1412770316-5241-1-git-send-email-minyard@acm.org>
In-Reply-To: <1412770316-5241-1-git-send-email-minyard@acm.org>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/3] Clean up non-blocking error
	reporting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: minyard@acm.org, qemu-devel@nongnu.org

Il 08/10/2014 14:11, minyard@acm.org ha scritto:
> This version makes the error message reporting more sane and
> adds a error_vreport() to make that easier.
> 
> It also cleans up the bool handling.
> 
> This depends on the previos non-blocking socket changes, which
> should hopefully be in qemu soon.

Looks good, but let's unify the error message like this:

+static void check_report_connect_error(CharDriverState *chr,
+                                       Error *err)
+{
+    TCPCharDriver *s = chr->opaque;
+
+    if (!s->connect_err_reported) {
+        error_report("Unable to connect character device %s: %s",
+                     chr->label, error_get_pretty(err));
+        s->connect_err_reported = true;
+    }
+    qemu_chr_socket_restart_timer(chr);
+}
+

This is an error on connecting the character device to the backend.  The
error on the socket is already detailed after the colon, thanks to your
patch 2.

I'll send a pull request today or tomorrow.

Thanks,

Paolo