From: Eric Blake <eblake@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-devel@nongnu.org
Cc: peter.huangpeng@huawei.com, luonengjun@huawei.com,
armbru@redhat.com, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v7 1/2] dump: Propagate errors into qmp_dump_guest_memory()
Date: Wed, 08 Oct 2014 08:50:26 -0600 [thread overview]
Message-ID: <54354F32.60903@redhat.com> (raw)
In-Reply-To: <1412068849-14848-2-git-send-email-zhang.zhanghailiang@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
On 09/30/2014 03:20 AM, zhanghailiang wrote:
> The code calls dump_error() on error, and even passes it a suitable
> message. However, the message is thrown away, and its callers pass
> up only success/failure. All qmp_dump_guest_memory() can do is set
> a generic error.
>
> Propagate the errors properly, so qmp_dump_guest_memory() can return
> a more useful error.
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> dump.c | 165 ++++++++++++++++++++++++++++++++---------------------------------
> 1 file changed, 82 insertions(+), 83 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-10-08 14:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 9:20 [Qemu-devel] [PATCH v7 0/2] Return error reasons to caller when calling qmp_dump_guest_memory zhanghailiang
2014-09-30 9:20 ` [Qemu-devel] [PATCH v7 1/2] dump: Propagate errors into qmp_dump_guest_memory() zhanghailiang
2014-10-08 14:50 ` Eric Blake [this message]
2014-09-30 9:20 ` [Qemu-devel] [PATCH v7 2/2] dump: Turn some functions to void to make code cleaner zhanghailiang
2014-10-08 0:53 ` zhanghailiang
2014-10-08 14:57 ` Eric Blake
2014-10-09 2:12 ` zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54354F32.60903@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=luonengjun@huawei.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).