From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbsZf-0006ZU-Dy for qemu-devel@nongnu.org; Wed, 08 Oct 2014 10:50:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XbsZW-0000MY-Vy for qemu-devel@nongnu.org; Wed, 08 Oct 2014 10:50:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbsZW-0000MG-Ki for qemu-devel@nongnu.org; Wed, 08 Oct 2014 10:50:34 -0400 Message-ID: <54354F32.60903@redhat.com> Date: Wed, 08 Oct 2014 08:50:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1412068849-14848-1-git-send-email-zhang.zhanghailiang@huawei.com> <1412068849-14848-2-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1412068849-14848-2-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rVLwqsxWCcLpkcQvitvjMTm8H8nWWIc82" Subject: Re: [Qemu-devel] [PATCH v7 1/2] dump: Propagate errors into qmp_dump_guest_memory() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: peter.huangpeng@huawei.com, luonengjun@huawei.com, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rVLwqsxWCcLpkcQvitvjMTm8H8nWWIc82 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/30/2014 03:20 AM, zhanghailiang wrote: > The code calls dump_error() on error, and even passes it a suitable > message. However, the message is thrown away, and its callers pass > up only success/failure. All qmp_dump_guest_memory() can do is set > a generic error. >=20 > Propagate the errors properly, so qmp_dump_guest_memory() can return > a more useful error. >=20 > Reviewed-by: Markus Armbruster > Signed-off-by: zhanghailiang > --- > dump.c | 165 ++++++++++++++++++++++++++++++++-------------------------= -------- > 1 file changed, 82 insertions(+), 83 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rVLwqsxWCcLpkcQvitvjMTm8H8nWWIc82 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUNU8yAAoJEKeha0olJ0NqaqUH/26YxhP8dfFVE+pzO7Rm26pg wz9m+JDQwZ3chqvCfX+en+JmErtj+gWc0sghfKBJjWfnd8efdWsd+YQdlMzrMFhC WM5OO1Ucz2kHX6yb7KlPVFEW5mHMZXwzpUFzBAXDdfbCIVQ5CxRRW8FYw9hsVW2I MyBuliHrNVilkaLpCmQNMzSfRvHTs8gRbNa7NdXpmz7drnCqtleR9EZCutmpK9NB am1p8YiMCan9owOi9fGHD9yjz4tcwlDLCr4GSYeYNRmPg9PrLHsLh87614Pvt45q ce6+wqx+rdhcjIB3Z67GAccjVAO7pySfyJvClhZhwYS/0Mgaq/VdtgrA6Uv7MM4= =WcbS -----END PGP SIGNATURE----- --rVLwqsxWCcLpkcQvitvjMTm8H8nWWIc82--