From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] raw-posix: raw_co_get_block_status() return value
Date: Wed, 08 Oct 2014 22:16:11 -0600 [thread overview]
Message-ID: <54360C0B.5050300@redhat.com> (raw)
In-Reply-To: <1411400179-10605-3-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
On 09/22/2014 09:36 AM, Max Reitz wrote:
> Instead of generating the full return value thrice in try_fiemap(),
> try_seek_hole() and as a fall-back in raw_co_get_block_status() itself,
> generate the value only in raw_co_get_block_status().
>
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> block/raw-posix.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-10-09 4:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 15:36 [Qemu-devel] [PATCH v2 0/2] raw-posix: Fix raw_co_get_block_status() Max Reitz
2014-09-22 15:36 ` [Qemu-devel] [PATCH v2 1/2] raw-posix: Fix raw_co_get_block_status() after EOF Max Reitz
2014-10-09 4:13 ` Eric Blake
2014-10-16 8:30 ` Kevin Wolf
2014-09-22 15:36 ` [Qemu-devel] [PATCH v2 2/2] raw-posix: raw_co_get_block_status() return value Max Reitz
2014-10-09 4:16 ` Eric Blake [this message]
2014-10-08 19:43 ` [Qemu-devel] [PATCH v2 0/2] raw-posix: Fix raw_co_get_block_status() Max Reitz
2014-10-09 18:58 ` Benoît Canet
2014-10-11 8:55 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54360C0B.5050300@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).