From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XcBhk-0002YK-BC for qemu-devel@nongnu.org; Thu, 09 Oct 2014 07:16:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XcBhS-0003du-Ko for qemu-devel@nongnu.org; Thu, 09 Oct 2014 07:16:18 -0400 Received: from mail-qg0-x230.google.com ([2607:f8b0:400d:c04::230]:52442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XcBhS-0003dm-9e for qemu-devel@nongnu.org; Thu, 09 Oct 2014 07:16:02 -0400 Received: by mail-qg0-f48.google.com with SMTP id i50so1438627qgf.35 for ; Thu, 09 Oct 2014 04:16:01 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <54366E69.6000808@redhat.com> Date: Thu, 09 Oct 2014 13:15:53 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1412668838-8656-1-git-send-email-arei.gonglei@huawei.com> <1412668838-8656-18-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1412668838-8656-18-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v11 17/34] net: remove bootindex property from qdev to qom List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, weidong.huang@huawei.com, mst@redhat.com, aik@ozlabs.ru, agraf@suse.de, kraxel@redhat.com, dmitry@daynix.com, akong@redhat.com, armbru@redhat.com, lersek@redhat.com, ehabkost@redhat.com, marcel.a@redhat.com, somlo@cmu.edu, luonengjun@huawei.com, peter.huangpeng@huawei.com, alex.williamson@redhat.com, stefanha@redhat.com, lcapitulino@redhat.com, rth@twiddle.net, kwolf@redhat.com, peter.crosthwaite@xilinx.com, chenliang88@huawei.com, imammedo@redhat.com, afaerber@suse.de Il 07/10/2014 10:00, arei.gonglei@huawei.com ha scritto: > From: Gonglei > > Remove bootindex form qdev property to qom, things will > continue to work just fine, and we can use qom features > which are not supported by qdev property. > > Signed-off-by: Gonglei > Reviewed-by: Gerd Hoffmann > --- > include/net/net.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/net/net.h b/include/net/net.h > index ed594f9..008d610 100644 > --- a/include/net/net.h > +++ b/include/net/net.h > @@ -36,8 +36,7 @@ typedef struct NICConf { > #define DEFINE_NIC_PROPERTIES(_state, _conf) \ > DEFINE_PROP_MACADDR("mac", _state, _conf.macaddr), \ > DEFINE_PROP_VLAN("vlan", _state, _conf.peers), \ > - DEFINE_PROP_NETDEV("netdev", _state, _conf.peers), \ > - DEFINE_PROP_INT32("bootindex", _state, _conf.bootindex, -1) > + DEFINE_PROP_NETDEV("netdev", _state, _conf.peers) > > > /* Net clients */ > This is a bit of a pity, and it's caused by the different nature of QOM properties (instance-based) vs. qdev properties (class-based). I can live with that. Paolo