From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XcEuN-0002ZF-Sf for qemu-devel@nongnu.org; Thu, 09 Oct 2014 10:41:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XcEuH-0003DD-Ra for qemu-devel@nongnu.org; Thu, 09 Oct 2014 10:41:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52465 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XcEuH-0003Cz-LC for qemu-devel@nongnu.org; Thu, 09 Oct 2014 10:41:29 -0400 Message-ID: <54369E98.901@suse.de> Date: Thu, 09 Oct 2014 16:41:28 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1411144812-22958-1-git-send-email-armbru@redhat.com> <8761g4cgq3.fsf@blackfin.pond.sub.org> <20141009094751.6e04b4b9@redhat.com> In-Reply-To: <20141009094751.6e04b4b9@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/1] hmp: Remove "info pcmcia" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino , Markus Armbruster , peter.maydell@linaro.org Cc: qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Am 09.10.2014 um 15:47 schrieb Luiz Capitulino: > On Wed, 01 Oct 2014 10:54:44 +0200 > Markus Armbruster wrote: >=20 >> Ping? >> >> Markus Armbruster writes: >> >>> This command lists PCMCIA sockets and cards. Only a few ARM boards >>> have sockets (akita, borzoi, connex, mainstone, spitz, terrier, tosa, >>> verdex, z2), the only card is the DSCM-1xxxx Hitachi Microdrive (qdev >>> "microdrive"), and it is only inserted during machine init, if ever. >>> So this command doesn't really tell anybody anything new so far. >>> >>> Moreover, pcmcia_socket_unregister() has a use-after-free bug, flagge= d >>> by Coverity. Has never been used, because there has never been code >>> to eject a PCMCIA card. >>> >>> Not worth fixing & converting to QMP. Remove it. >=20 > Sorry for the long delay on this one. But this patch is more about PCMC= IA > support in QEMU than HMP, so I can provide my ACK, but I don't think th= is > is HMP material. >=20 > Acked-by: Luiz Capitulino As the probably last one to have touched the ugly PCMCIA code, Acked-by: Andreas F=E4rber Maybe take it through the arm queue due to affected machines, Peter? Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg