From: Paolo Bonzini <pbonzini@redhat.com>
To: Wei Huang <wei@redhat.com>, afaerber@suse.de, ehabkost@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] target-i386: prevent users from setting threads>1 for AMD CPUs
Date: Thu, 09 Oct 2014 23:08:03 +0200 [thread overview]
Message-ID: <5436F933.8080204@redhat.com> (raw)
In-Reply-To: <5436EE6A.6030705@redhat.com>
Il 09/10/2014 22:22, Wei Huang ha scritto:
>
> Given that back-ward compatibility is a concern, will the following work?
>
> 1. Instead of bailing out, print a warning message (e.g. to log file via
> error_report) in QEMU.
> 2. [optional] Eduardo Habkost suggested that we can create a new machine
> model which more strictly checks threads=n option for AMD. For any
> existing machine config, we don't force it; but warning message still
> applies. This is optional because it is a bit over-killed IMO.
> 3. Gives out a warning in virt-manager as well. This is similar to
> "Overcomming CPUs will slow down performance" in current virt-manager
> screen. The message will read "Chosen CPU model doesn't support
> hyperthreading" or something similar.
I like (1) and (3).
Paolo
next prev parent reply other threads:[~2014-10-09 21:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 19:44 [Qemu-devel] [PATCH 1/1] target-i386: prevent users from setting threads>1 for AMD CPUs Wei Huang
2014-10-07 20:58 ` Paolo Bonzini
2014-10-07 21:16 ` Wei Huang
2014-10-07 21:36 ` Paolo Bonzini
2014-10-08 0:41 ` Wei Huang
2014-10-08 7:47 ` Paolo Bonzini
2014-10-09 20:22 ` Wei Huang
2014-10-09 21:08 ` Paolo Bonzini [this message]
2014-10-09 22:16 ` Eduardo Habkost
2014-10-21 15:11 ` Wei Huang
-- strict thread matches above, loose matches on Subject: below --
2014-10-07 19:17 Wei Huang
2014-10-07 19:42 ` Wei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5436F933.8080204@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).