From: Chen Gang <gang.chen.5i5j@gmail.com>
To: Eric Blake <eblake@redhat.com>,
peter.maydell@linaro.org, "rth@twiddle.net" <rth@twiddle.net>
Cc: qemu-trivial@nongnu.org, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror'
Date: Fri, 10 Oct 2014 09:28:25 +0800 [thread overview]
Message-ID: <54373639.4010005@gmail.com> (raw)
In-Reply-To: <5436A1AA.8020004@redhat.com>
On 10/9/14 22:54, Eric Blake wrote:
> On 10/09/2014 08:00 AM, Chen Gang wrote:
>
> That's a very long subject line. Try to keep subjects around 60
> characters or so ('git shortlog -30' can give you an idea of reasonable
> subjects).
OK, thanks, I shall notice about it next (also let 'git shortlog -30' as
reference).
> Also, s/varialbe/variable/ in the subject.
>
>> The related variables are useless, need be removed, or can not pass
OK, thanks. If this patch can still continue (pass checking), I shall
send patch v2 for it.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
next prev parent reply other threads:[~2014-10-10 1:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 14:00 [Qemu-devel] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror' Chen Gang
2014-10-09 14:34 ` Peter Maydell
2014-10-10 1:54 ` Chen Gang
2014-10-10 7:37 ` Peter Maydell
2014-10-10 8:53 ` Chen Gang
2014-10-10 9:03 ` Chen Gang
2014-10-09 14:54 ` Eric Blake
2014-10-10 1:28 ` Chen Gang [this message]
2014-10-21 15:50 ` Peter Maydell
2014-10-23 6:49 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-10-23 7:14 ` Peter Maydell
2014-10-23 8:09 ` Michael Tokarev
2014-10-23 9:02 ` Peter Maydell
2014-10-23 10:09 ` Peter Maydell
2014-10-23 10:27 ` Michael Tokarev
2014-10-23 11:05 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2014-10-21 23:27 [Qemu-devel] " Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54373639.4010005@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).