From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XcOv0-0001po-Lc for qemu-devel@nongnu.org; Thu, 09 Oct 2014 21:23:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XcOuq-0004dQ-Oj for qemu-devel@nongnu.org; Thu, 09 Oct 2014 21:22:54 -0400 Message-ID: <54373639.4010005@gmail.com> Date: Fri, 10 Oct 2014 09:28:25 +0800 From: Chen Gang MIME-Version: 1.0 References: <54369514.5000004@gmail.com> <5436A1AA.8020004@redhat.com> In-Reply-To: <5436A1AA.8020004@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , peter.maydell@linaro.org, "rth@twiddle.net" Cc: qemu-trivial@nongnu.org, qemu-devel On 10/9/14 22:54, Eric Blake wrote: > On 10/09/2014 08:00 AM, Chen Gang wrote: > > That's a very long subject line. Try to keep subjects around 60 > characters or so ('git shortlog -30' can give you an idea of reasonable > subjects). OK, thanks, I shall notice about it next (also let 'git shortlog -30' as reference). > Also, s/varialbe/variable/ in the subject. > >> The related variables are useless, need be removed, or can not pass OK, thanks. If this patch can still continue (pass checking), I shall send patch v2 for it. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed