Re: [Qemu-devel] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror'

[Chen Gang <gang.chen.5i5j@gmail.com>]

On 10/9/14 22:34, Peter Maydell wrote:
> On 9 October 2014 15:00, Chen Gang <gang.chen.5i5j@gmail.com> wrote:
>> The related variables are useless, need be removed, or can not pass
>> microblaze building, after fix it, can build microblaze, successfully.
>>
>> The related configuration:
>>
>>  ./configure --target-list="arm-softmmu,microblazeel-softmmu" --enable-fdt --disable-kvm
>>
>> The related compiling error:
> 
> I build this code with both these targets enabled without any
> problems.
> 
> There is an odd compiler thing where if you have any *other*
> compilation issues then these warnings will also be emitted,
> but once you've fixed that other compiler error then these
> warnings are no longer produced. Maybe you ran into that?
> 

I use the latest upstream gcc (which pulled from master in 2014-10-0?).
In my memory (not quite sure), the older version gcc may not notice
about this warning.

But for me, the warning (compiler worries about) sounds reasonable, and
it's harmless to be fixed (after have a look, for me, they are declared,
but never be used).

> The reason I'm reluctant to make changes to these files is
> that they're pulled in from a different upstream project
> (libvixl) so we should only fix critical problems in them,
> or it makes new versions harder to update to.
> 

Originally, I first try the Xilinx branch (Xilinx-master from Xilinx
github), yesterday, and found this issue, then I try upstream main
branch, found the same issue.

For me, when add the related patch (which will use these variables in
'libvixl'), then declare and set them in the related headers, again.
That will let other reviewers and readers easier understanding.

 - removing them at present, is easy understanding.

 - add them again when really need them, is also easy understanding.

So for me, I still prefer to remove these declarations firstly.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed