From: Fabien Chouteau <chouteau@adacore.com>
To: Jiri Gaisler <jiri@gaisler.se>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk
Subject: Re: [Qemu-devel] [PATCH V2] LEON3: Add emulation of AMBA plug&play
Date: Fri, 10 Oct 2014 11:04:36 +0200 [thread overview]
Message-ID: <5437A124.3090807@adacore.com> (raw)
In-Reply-To: <5436AA82.9@gaisler.se>
On 10/09/2014 05:32 PM, Jiri Gaisler wrote:
>
> I am a bit against the merge of AHB and APB initialization into
> the same function. A grlib system can have any number of AHB and APB
> buses, so there really should be a separate init routine per bus
> as in the original patch.
>
I understand your concerns, for the moment the system definition of
leon3 is very static, and I don't see that we will need more flexibility
in the near future. In that case I think it's better to not add
unnecessary complexity in the code.
prev parent reply other threads:[~2014-10-10 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 11:05 [Qemu-devel] [PATCH V2] LEON3: Add emulation of AMBA plug&play Fabien Chouteau
2014-10-09 15:32 ` Jiri Gaisler
2014-10-10 9:04 ` Fabien Chouteau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5437A124.3090807@adacore.com \
--to=chouteau@adacore.com \
--cc=jiri@gaisler.se \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).