From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XcW7s-00047v-VM for qemu-devel@nongnu.org; Fri, 10 Oct 2014 05:04:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XcW7s-0003cS-8T for qemu-devel@nongnu.org; Fri, 10 Oct 2014 05:04:40 -0400 Received: from mel.v6.act-europe.fr ([2a02:2ab8:224:1::a0a:d2]:50562 helo=smtp.eu.adacore.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XcW7s-0003cG-3a for qemu-devel@nongnu.org; Fri, 10 Oct 2014 05:04:40 -0400 Message-ID: <5437A124.3090807@adacore.com> Date: Fri, 10 Oct 2014 11:04:36 +0200 From: Fabien Chouteau MIME-Version: 1.0 References: <1412852725-24916-1-git-send-email-chouteau@adacore.com> <5436AA82.9@gaisler.se> In-Reply-To: <5436AA82.9@gaisler.se> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2] LEON3: Add emulation of AMBA plug&play List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jiri Gaisler , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk On 10/09/2014 05:32 PM, Jiri Gaisler wrote: > > I am a bit against the merge of AHB and APB initialization into > the same function. A grlib system can have any number of AHB and APB > buses, so there really should be a separate init routine per bus > as in the original patch. > I understand your concerns, for the moment the system definition of leon3 is very static, and I don't see that we will need more flexibility in the near future. In that case I think it's better to not add unnecessary complexity in the code.