qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH build-fix] kvm fix compilation with GCC 4.3.4
Date: Fri, 10 Oct 2014 13:20:06 +0200	[thread overview]
Message-ID: <5437C0E6.3010104@de.ibm.com> (raw)
In-Reply-To: <1412936615-18397-1-git-send-email-pbonzini@redhat.com>

Am 10.10.2014 12:23, schrieb Paolo Bonzini:
> As usual, SLES11's GCC complained about double typedefs:

RHEL 6.5 gcc 4.4.7 complains as well. :-)

This fix helps there as well.

> 
> /home/cohuck/git/qemu/kvm-all.c:110: error: redefinition of typedef ‘KVMState’
> /home/cohuck/git/qemu/include/sysemu/kvm.h:161: error: previous declaration of ‘KVMState’ was here
> 
> Reported-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  kvm-all.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kvm-all.c b/kvm-all.c
> index e98a7c7..44a5e72 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -71,7 +71,7 @@ typedef struct KVMSlot
> 
>  typedef struct kvm_dirty_log KVMDirtyLog;
> 
> -typedef struct KVMState
> +struct KVMState
>  {
>      AccelState parent_obj;
> 
> @@ -107,7 +107,7 @@ typedef struct KVMState
>      QTAILQ_HEAD(msi_hashtab, KVMMSIRoute) msi_hashtab[KVM_MSI_HASHTAB_SIZE];
>      bool direct_msi;
>  #endif
> -} KVMState;
> +};
> 
>  #define TYPE_KVM_ACCEL ACCEL_CLASS_NAME("kvm")
> 

  reply	other threads:[~2014-10-10 11:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10 10:23 [Qemu-devel] [PATCH build-fix] kvm fix compilation with GCC 4.3.4 Paolo Bonzini
2014-10-10 11:20 ` Christian Borntraeger [this message]
2014-10-10 13:55 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5437C0E6.3010104@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).