From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XccpQ-0006U0-KS for qemu-devel@nongnu.org; Fri, 10 Oct 2014 12:14:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XccpL-0002vT-Mw for qemu-devel@nongnu.org; Fri, 10 Oct 2014 12:14:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XccpL-0002vN-1S for qemu-devel@nongnu.org; Fri, 10 Oct 2014 12:13:59 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9AGDvMo004142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 10 Oct 2014 12:13:58 -0400 Message-ID: <543805C4.50204@redhat.com> Date: Fri, 10 Oct 2014 10:13:56 -0600 From: Eric Blake MIME-Version: 1.0 References: <1410411902-7104-1-git-send-email-famz@redhat.com> <1410411902-7104-3-git-send-email-famz@redhat.com> In-Reply-To: <1410411902-7104-3-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n9IDAcp7QTgK1WVgl7w5DdG9OEQ8UNkN8" Subject: Re: [Qemu-devel] [PATCH 2/3] block: Add blockdev-backup to transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , pbonzini@redhat.com, Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --n9IDAcp7QTgK1WVgl7w5DdG9OEQ8UNkN8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/10/2014 11:05 PM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > blockdev.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++= > qapi-schema.json | 3 +++ > 2 files changed, 51 insertions(+) >=20 > +++ b/qapi-schema.json > @@ -1251,11 +1251,14 @@ > # > # A discriminated record of operations that can be performed with > # @transaction. > +# > +# Since 1.1, blockdev-backup since 2.1 If we're going to do this, we should be accurate. s/2.1/2.2. Furthermor= e: drive-backup and abort were added in 1.6 blockdev-snapshot-internal-sync was added in 1.7 (but yes, I'm glad that you are wanting to add version information). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --n9IDAcp7QTgK1WVgl7w5DdG9OEQ8UNkN8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUOAXEAAoJEKeha0olJ0NqG2UIAJYkFdDbkc+RecJTgCRdXVqV UFEQ9Mfbo3+D+8PBwWseNr4Ev0mNoREQfE/YsYQYlmKQLWyQz5GrGs49EVEdxV5g pCVNx0AAW8vMHVocK0qxGZKW463DZWl4hnhtltGQHS+0PkgF4p10FyW1ahn1qa2A NznaLUqMifoIyG51WFcnjWkRom01nZf2zQDh85vDomvOjVnyIi2C/Derrbp0qQuz pgMOy3CYjUTIe3Fd0C/YB4ssAkGKfgNgq2lMFO7Dx/tI1G7PJ8Ws5LG33GzZLBHe N4bmp4HvwjwZZJI3+NE0WS3Bl75NYP5j1vM3kBaZMxV/krKwCdH6bBjbIWs56xU= =yBH4 -----END PGP SIGNATURE----- --n9IDAcp7QTgK1WVgl7w5DdG9OEQ8UNkN8--