From: Eric Blake <eblake@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
qemu-devel@nongnu.org
Cc: joel.schopp@amd.com, zhang.zhanghailiang@huawei.com,
quintela@redhat.com, stefanb@linux.vnet.ibm.com,
armbru@redhat.com, arei.gonglei@huawei.com,
sanidhya.iiith@gmail.com
Subject: Re: [Qemu-devel] [PATCH v6 0/2] In memory QEMUFile
Date: Fri, 10 Oct 2014 10:22:36 -0600 [thread overview]
Message-ID: <543807CC.6010000@redhat.com> (raw)
In-Reply-To: <1412941145-14023-1-git-send-email-dgilbert@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]
On 10/10/2014 05:39 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> This patch-pair adds the QEMUSizedBuffer based in-memory QEMUFile
> written by Stefan Berger and Joel Schopp. I've made some
> fixes and modified the existing test-vmstate to use it for some test cases.
>
> While there's nothing other than test cases using it yet, I think
> it's worth going in by itself, since I'm using it in two separate
> patchsets (postcopy and visitor/BER) and Sanidhya uses it in
> the periodic vmstate test world. In addition both microcheckpointing and
> COLO have similar but independent implementations (although they both
> have some extra-gotcha's so it might not be possible to reuse it), and
> there was another implementation of the same thing in the Yabusame Postcopy
> world. Thus it seems best to put in, if only to stop people writing yet
> another implementation.
>
> (Eric I've kept your reviewed-by from v5 - please confirm you're OK)
>
> Dave
>
> v6:
> Build fixes for older compiler/glib reported by zhang.zhanghailiang@huawei.com
> removed: typedef QEMUSizedBuffer from qemu-file.h
> used g_try_new rather than g_try_malloc_n
Yes, my R-b is still okay, after checking that these are indeed the only
changes.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-10-10 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 11:39 [Qemu-devel] [PATCH v6 0/2] In memory QEMUFile Dr. David Alan Gilbert (git)
2014-10-10 11:39 ` [Qemu-devel] [PATCH v6 1/2] QEMUSizedBuffer based QEMUFile Dr. David Alan Gilbert (git)
2014-10-10 11:39 ` [Qemu-devel] [PATCH v6 2/2] Tests: QEMUSizedBuffer/QEMUBuffer Dr. David Alan Gilbert (git)
2014-10-10 16:22 ` Eric Blake [this message]
2014-10-14 7:21 ` [Qemu-devel] [PATCH v6 0/2] In memory QEMUFile Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543807CC.6010000@redhat.com \
--to=eblake@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=joel.schopp@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=sanidhya.iiith@gmail.com \
--cc=stefanb@linux.vnet.ibm.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).