From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49568)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XcsU3-0002JX-Hk
	for qemu-devel@nongnu.org; Sat, 11 Oct 2014 04:57:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XcsTx-0006Xx-DO
	for qemu-devel@nongnu.org; Sat, 11 Oct 2014 04:57:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9366)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XcsTx-0006Wi-62
	for qemu-devel@nongnu.org; Sat, 11 Oct 2014 04:56:57 -0400
Message-ID: <5438F06F.30900@redhat.com>
Date: Sat, 11 Oct 2014 10:55:11 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1411400179-10605-1-git-send-email-mreitz@redhat.com>
	<543593D7.4070909@redhat.com> <20141009185845.GA5717@nodalink.com>
In-Reply-To: <20141009185845.GA5717@nodalink.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 0/2] raw-posix: Fix
	raw_co_get_block_status()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?windows-1252?Q?Beno=EEt_Canet?= <benoit.canet@nodalink.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 09.10.2014 um 20:58 schrieb Beno=EEt Canet:
> On Wed, Oct 08, 2014 at 09:43:19PM +0200, Max Reitz wrote:
>> On 22.09.2014 17:36, Max Reitz wrote:
>>> raw_co_get_block_status() should return 0 and set *pnum to 0 after th=
e
>>> EOF; currently it does this merely by accident, so implement it
>>> directly. Also, nb_sectors should be clamped against the image end.
>>>
>>> While doing that, centralize the generation of
>>> raw_co_get_block_status()'s return value along the way.
>>>
>>>
>>> v2:
>>> - Patch 1: Clamp nb_sectors against image end
>>> - Patch 2: Fix alignment issue
>>>
>>>
>>> Max Reitz (2):
>>>    raw-posix: Fix raw_co_get_block_status() after EOF
>>>    raw-posix: raw_co_get_block_status() return value
>>>
>>>   block/raw-posix.c | 36 ++++++++++++++++++++++--------------
>>>   1 file changed, 22 insertions(+), 14 deletions(-)
>> Ping. (This should be rather simple to review)
> Hi Max,
>
> I will review these tomorow.

Thanks a lot for all of your reviews!

Max