From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XdDeD-0005a8-QU for qemu-devel@nongnu.org; Sun, 12 Oct 2014 03:33:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XdDe7-0006hY-Bu for qemu-devel@nongnu.org; Sun, 12 Oct 2014 03:32:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XdDe7-0006gs-4e for qemu-devel@nongnu.org; Sun, 12 Oct 2014 03:32:51 -0400 Message-ID: <543A2E98.1070806@redhat.com> Date: Sun, 12 Oct 2014 09:32:40 +0200 From: Max Reitz MIME-Version: 1.0 References: <1409348463-16627-1-git-send-email-mreitz@redhat.com> <1409348463-16627-9-git-send-email-mreitz@redhat.com> <20141011185625.GA25059@nodalink.com> In-Reply-To: <20141011185625.GA25059@nodalink.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 08/11] qcow2: Rebuild refcount structure during check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?windows-1252?Q?Beno=EEt_Canet?= Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi Am 11.10.2014 um 20:56 schrieb Beno=EEt Canet: >> + int64_t first_free_cluster =3D 0, rt_ofs =3D -1, cluster =3D 0; >> + int64_t rb_ofs, rb_start, rb_index; > Everytime a few day pass and I read rb_ofs and rt_ofs again I found the= se names > obfuscated. I know Linus says that C is a spartan language but these lo= ok odd. > Maybe refcount_block_offset, refcount_block_* and refcount_table_offset= would be > better. I would use longer names if there was no line length limit. ;-) I'll try and see how it looks. Max