From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XdH5n-000276-Rw for qemu-devel@nongnu.org; Sun, 12 Oct 2014 07:13:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XdH5e-0006O1-MS for qemu-devel@nongnu.org; Sun, 12 Oct 2014 07:13:39 -0400 Received: from mail-pa0-x232.google.com ([2607:f8b0:400e:c03::232]:35619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XdH5e-0006Nt-EY for qemu-devel@nongnu.org; Sun, 12 Oct 2014 07:13:30 -0400 Received: by mail-pa0-f50.google.com with SMTP id kx10so4390059pab.9 for ; Sun, 12 Oct 2014 04:13:29 -0700 (PDT) Message-ID: <543A63B9.2090203@gmail.com> Date: Sun, 12 Oct 2014 19:19:21 +0800 From: Chen Gang MIME-Version: 1.0 References: <5439399D.4020004@gmail.com> <54393AF0.1010708@gmail.com> <5439CC2F.2050702@gmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] libvixl: a64: Skip "-Wunused-variable" for gcc 5.0.0 or higher List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel , Richard Henderson On 10/12/14 15:50, Peter Maydell wrote: > On 12 October 2014 01:32, Chen Gang wrote: >> On 10/12/14 5:25, Peter Maydell wrote: >>> Some other approaches to this that would confine the >>> fix to the makefiles rather than requiring us to modify >>> the vixl source itself: >>> a) add a -Wno- option for the affected .o files >> >> It is one way, but may have effect with gcc 4 version, and also it is >> effect with the whole file which is wider than current way. >> >>> b) use -isystem rather than -I to include the libvixl >>> directory on the include path >>> >> >> It sounds good to me, although for me, it is not related with current >> issue. > > -isystem disables a bunch of gcc warnings automatically, > which is why I suggested it. I'm not overall sure it's > a great idea though. > OK, thanks. "-isystem" really can skip this warning, originally, I am not notice about it. :-) But unlucky, other files within 'libvix' which also include this header file, also report this warning. So for me, it is not a good idea to let '-isystem' for the 'libvix' own source files. Next, I shall firstly confirm whether it is a gcc 5.0 (g++) issue or not in gcc upstream mailing list. - if it is gcc 5.0 issue, I shall try to fix it within this month. - else, for me, this patch v2 can still continue. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed