From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55620)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1XdXdu-0001vk-9p
	for qemu-devel@nongnu.org; Mon, 13 Oct 2014 00:54:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1XdXdp-0006h1-Ez
	for qemu-devel@nongnu.org; Mon, 13 Oct 2014 00:53:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35768)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1XdXdo-0006gr-TS
	for qemu-devel@nongnu.org; Mon, 13 Oct 2014 00:53:53 -0400
Message-ID: <543B5ADA.5070308@redhat.com>
Date: Mon, 13 Oct 2014 12:53:46 +0800
From: Jason Wang <jasowang@redhat.com>
MIME-Version: 1.0
References: <1410232205-39473-1-git-send-email-jasowang@redhat.com>	<87bnpkkrfn.fsf@blackfin.pond.sub.org>
	<543B4784.4030603@redhat.com>
In-Reply-To: <543B4784.4030603@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V2] net: don't use set/get_pointer() in
	set/get_netdev()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, mst@redhat.com, afaerber@suse.de, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org

On 10/13/2014 11:31 AM, Jason Wang wrote:
> On 10/10/2014 09:03 PM, Markus Armbruster wrote:
>> Jason Wang <jasowang@redhat.com> writes:
>>
>>> Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue
>>> support) tries to use set_pointer() and get_pointer() to set and get
>>> NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This
>>> trick works but result a unclean and fragile implementation (e.g
>>> print_netdev and parse_netdev).
>>>
>>> This patch solves this issue by not using set/get_pinter() and set and
>>> get netdev directly in set_netdev() and get_netdev(). After this the
>>> parse_netdev() and print_netdev() were no longer used and dropped from
>>> the source.
>>>
>>> Cc: Markus Armbruster <armbru@redhat.com>
>>> Cc: Stefan Hajnoczi <stefanha@redhat.com>
>>> Cc: Peter Maydell <peter.maydell@linaro.org>
>>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>>> ---
>>> Changes from V1:
>>> - validate ncs pointer before accessing them, this fixes the qtest failure
>>>   on arm.
>>> ---
>>>  hw/core/qdev-properties-system.c | 71 ++++++++++++++++++++++------------------
>>>  1 file changed, 39 insertions(+), 32 deletions(-)
>>>
>>> diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
>>> index ae0900f..6939ea5 100644
>>> --- a/hw/core/qdev-properties-system.c
>>> +++ b/hw/core/qdev-properties-system.c
>>> @@ -176,41 +176,67 @@ PropertyInfo qdev_prop_chr = {
>>>  };
>>>  
[...]
>>>          goto err;
>>>      }
>>>  
>>>      for (i = 0; i < queues; i++) {
>>>          if (peers[i] == NULL) {
>>> -            ret = -ENOENT;
>>> +            err = -ENOENT;
>>>              goto err;
>>>          }
>>>  
>>>          if (peers[i]->peer) {
>>> -            ret = -EEXIST;
>>> +            err = -EEXIST;
>>>              goto err;
>>>          }
>>>  
>>>          if (ncs[i]) {
>>> -            ret = -EINVAL;
>>> +            err = -EINVAL;
>> error_set_from_qdev_prop_error() does not accept -EINVAL, either.
> Ok.

Just have a check, error_set_from_qdev_prop_error() can accept -EINVAL,
so I will only call error_setg() directly for -E2BIG.