From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xdh6K-0007I7-Lb for qemu-devel@nongnu.org; Mon, 13 Oct 2014 11:00:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xdh6F-0001m1-K9 for qemu-devel@nongnu.org; Mon, 13 Oct 2014 10:59:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xdh6F-0001lw-BG for qemu-devel@nongnu.org; Mon, 13 Oct 2014 10:59:51 -0400 Message-ID: <543BE8E2.7090307@redhat.com> Date: Mon, 13 Oct 2014 08:59:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <5439399D.4020004@gmail.com> <54393AF0.1010708@gmail.com> <5439CC2F.2050702@gmail.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XmguDMoVUT7AUVlTdrPMifX8svbjNK3X4" Subject: Re: [Qemu-devel] [PATCH v2] libvixl: a64: Skip "-Wunused-variable" for gcc 5.0.0 or higher List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Chen Gang Cc: qemu-devel , Richard Henderson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XmguDMoVUT7AUVlTdrPMifX8svbjNK3X4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/12/2014 01:50 AM, Peter Maydell wrote: > On 12 October 2014 01:32, Chen Gang wrote: >> On 10/12/14 5:25, Peter Maydell wrote: >>> Some other approaches to this that would confine the >>> fix to the makefiles rather than requiring us to modify >>> the vixl source itself: >>> a) add a -Wno- option for the affected .o files >> >> It is one way, but may have effect with gcc 4 version, and also it is >> effect with the whole file which is wider than current way. >> >>> b) use -isystem rather than -I to include the libvixl >>> directory on the include path >>> >> >> It sounds good to me, although for me, it is not related with current >> issue. >=20 > -isystem disables a bunch of gcc warnings automatically, > which is why I suggested it. I'm not overall sure it's > a great idea though. -isystem is a heavy hammer, affecting the entire compilation. Better might be just marking the ONE header as being a system header (silence various warnings caused by just that header, while still letting the rest of the compilation warn). If the header comes from third-party sources, this is probably the best approach. It is done by adding: #if __GNUC__ >=3D 3 #pragma GCC system_header #endif to the header that would otherwise trigger warnings. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XmguDMoVUT7AUVlTdrPMifX8svbjNK3X4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUO+jiAAoJEKeha0olJ0NqtEUH/jMUQW+mpAOgbY4E5bAE9aGX mxQhxmcnNAhTt/sZNR5tMaubMcMT20NrAz04JUQIF1386I1jLUIO5flm3SCJlDCU U398zwTp+2NM8nu8EjVahVUwny2UeQRX0NNKl40oWLaAZTtzCz4n/PfOYnuB12xu llsXlZ8BkZA6bvNp2wW+11p1SQv7uclYGydMvIf4xBtvDnDtshzfUAi6AWqMxlon lOGDLPC15zLA4G9rqRVDaKVAaX8e4T+ocfIc7/Dcq08oo+qCojpJndFmTYdqb63g G/OYQcx/0AVFLhtZqBtGvYWpyzU3YAAa1VwPbWhxisq95kbI6dthsATa9LFDQDo= =W3OS -----END PGP SIGNATURE----- --XmguDMoVUT7AUVlTdrPMifX8svbjNK3X4--