From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51276)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XdioZ-0004t9-72
	for qemu-devel@nongnu.org; Mon, 13 Oct 2014 12:49:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XdioU-0003KO-BI
	for qemu-devel@nongnu.org; Mon, 13 Oct 2014 12:49:43 -0400
Received: from mail-qg0-x234.google.com ([2607:f8b0:400d:c04::234]:64487)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XdioU-0003KG-5x
	for qemu-devel@nongnu.org; Mon, 13 Oct 2014 12:49:38 -0400
Received: by mail-qg0-f52.google.com with SMTP id q108so6905705qgd.25
	for <qemu-devel@nongnu.org>; Mon, 13 Oct 2014 09:49:37 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <543C029D.1000609@twiddle.net>
Date: Mon, 13 Oct 2014 09:49:33 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1413217624-14415-1-git-send-email-kbastian@mail.uni-paderborn.de>
	<1413217624-14415-6-git-send-email-kbastian@mail.uni-paderborn.de>
In-Reply-To: <1413217624-14415-6-git-send-email-kbastian@mail.uni-paderborn.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 5/5] target-tricore: Add instructions of
 BO opcode format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org

On 10/13/2014 09:27 AM, Bastian Koppelmann wrote:
> Add instructions of BO opcode format.
> Add microcode generator functions gen_swap, gen_ldmst.
> Add microcode generator functions gen_st/ld_preincr, which write back the address after the memory access.
> Add helper for circular and bit reverse addr mode calculation.
> Add sign extended bitmask for BO_OFF10 field.
> 
> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> ---
> v2 -> v3:
>     - Add microcode generator functions gen_st/ld_preincr, which write back the
>       address after the memory access.
>     - ST/LD_PREINC insn now use gen_st/ld_preincr or write back the address after
>       after the memory access.

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~