From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43613)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <haifeng.lin@huawei.com>) id 1XeDSW-0003BK-QX
	for qemu-devel@nongnu.org; Tue, 14 Oct 2014 21:33:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <haifeng.lin@huawei.com>) id 1XeDSQ-0006aY-EJ
	for qemu-devel@nongnu.org; Tue, 14 Oct 2014 21:33:00 -0400
Received: from szxga01-in.huawei.com ([119.145.14.64]:43017)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <haifeng.lin@huawei.com>) id 1XeDSP-0006WP-Nj
	for qemu-devel@nongnu.org; Tue, 14 Oct 2014 21:32:54 -0400
Message-ID: <543DCEA6.7090304@huawei.com>
Date: Wed, 15 Oct 2014 09:32:22 +0800
From: Linhaifeng <haifeng.lin@huawei.com>
MIME-Version: 1.0
References: <543D10DE.2080109@huawei.com> <20141014120815.GA29671@redhat.com>
In-Reply-To: <20141014120815.GA29671@redhat.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Bug?]When close VM the hugepage not freed
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, lilijun <jerry.lilijun@huawei.com>



On 2014/10/14 20:08, Daniel P. Berrange wrote:
> On Tue, Oct 14, 2014 at 08:02:38PM +0800, Linhaifeng wrote:
>> Hi,all
>>
>> I was trying to use hugepage with VM and found that the hugepage not freed when close VM.
>>
>>
>> 1.Before start VM the /proc/meminfo is:
>> AnonHugePages:    124928 kB
>> HugePages_Total:    4096
>> HugePages_Free:     3072
>> HugePages_Rsvd:        0
>> HugePages_Surp:        0
>> Hugepagesize:       2048 kB
>>
>> 2.Start VM the /proc/meminfo is:
>> AnonHugePages:    139264 kB
>> HugePages_Total:    4096
>> HugePages_Free:     2048
>> HugePages_Rsvd:        0
>> HugePages_Surp:        0
>> Hugepagesize:       2048 kB
>>
>> 3.Close VM the /proc/meminfo is:
>> AnonHugePages:    124928 kB
>> HugePages_Total:    4096
>> HugePages_Free:     2048
>> HugePages_Rsvd:        0
>> HugePages_Surp:        0
>> Hugepagesize:       2048 kB
>>
>> We can see there are 1024 hugepage leak!
>>
>> I try to found which function used to free hugepage but i'm not sure
>> where the qemu_ram_free is the function to free hugepage.
>> I found that the qemu_ram_free function not call unlink and we know
>> unlink is used to free hugepage(see example of hugepage-mmap.c in
>> kernel source).
> 
> We can't rely on 'qemu_ram_free' ever executing because we must
> ensure hugepages are freed upon QEMU crash.
> 
> It seems we should rely on UNIX filesytstem semantics and simply
> unlink the memory segment the moment we create it & open the FD.
> That way the kernel will automatically free it when the FD is
> closed when QEMU process exits.
> 
> 
> Regards,
> Daniel
> 

Hi, daniel

Thank you for your answer.

Does it means libvirt should free the hugepage?

QEMU create the hugepage with template file and unlink it before mmap.
Do you know why to unlink the hugepage before mmap?

When unlink the hugepage before mmap libvirt cannot found the hugepage.
How does libvirt to free the hugepage ?

Regards,
Haifeng