From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56350)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Xei2E-00046k-Oo
	for qemu-devel@nongnu.org; Thu, 16 Oct 2014 06:11:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Xei29-00072u-UR
	for qemu-devel@nongnu.org; Thu, 16 Oct 2014 06:11:54 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:6011)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Xei29-00070C-49
	for qemu-devel@nongnu.org; Thu, 16 Oct 2014 06:11:49 -0400
Message-ID: <543F99C5.100@huawei.com>
Date: Thu, 16 Oct 2014 18:11:17 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1413363967-2489-1-git-send-email-kraxel@redhat.com>
	<1413363967-2489-4-git-send-email-kraxel@redhat.com>
	<CAFEAcA-3PT9jNxZctPkDvWGU_qtH7pM2SixGW1GBLU3Vy1qiDg@mail.gmail.com>
In-Reply-To: <CAFEAcA-3PT9jNxZctPkDvWGU_qtH7pM2SixGW1GBLU3Vy1qiDg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 03/34] bootindex: add del_boot_device_path
 function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "chenliang (T)" <chenliang88@huawei.com>, Gerd Hoffmann <kraxel@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On 2014/10/16 18:04, Peter Maydell wrote:

> On 15 October 2014 11:05, Gerd Hoffmann <kraxel@redhat.com> wrote:
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> Introduce del_boot_device_path() to clean up fw_cfg content when
>> hot-unplugging a device that refers to a bootindex or update a
>> existent devcie's bootindex.
> 
>> +void del_boot_device_path(DeviceState *dev, const char *suffix)
>> +{
>> +    FWBootEntry *i;
>> +
>> +    if (dev == NULL) {
>> +        return;
>> +    }
>> +
>> +    QTAILQ_FOREACH(i, &fw_boot_order, link) {
>> +        if ((!suffix || !g_strcmp0(i->suffix, suffix)) &&
> 
> I've just noticed that this won't build with our minimum
> required glib version: g_strcmp0 wasn't introduced
> until glib 2.16.
> 
> It should be fairly easy to provide a back-compat implementation
> in our glib-compat.h header, or you could just rephrase this
> to work with the usual strcmp, since you're already doing a
> manual NULL check on one of the arguments.
> 

OK, thanks for your point, Peter.
I'll post a patch to fix this problem :)

Best regards,
-Gonglei