[Qemu-devel] [PATCH] block: fix implicit convertion to invalid type

[Qemu-devel] [PATCH] block: fix implicit convertion to invalid type

[Igor Mammedov]

change type of variable to expected IoOperationType which fixes compile
warning:

block.c:3655:20: warning: implicit conversion from enumeration
 type enum IoOperationType to different enumeration type BlockErrorAction

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 block.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/block.c b/block.c
index 27533f3..c15fad0 100644
--- a/block.c
+++ b/block.c
@@ -3650,10 +3650,10 @@ static void send_qmp_error_event(BlockDriverState *bs,
                                  BlockErrorAction action,
                                  bool is_read, int error)
 {
-    BlockErrorAction ac;
+    IoOperationType op;
 
-    ac = is_read ? IO_OPERATION_TYPE_READ : IO_OPERATION_TYPE_WRITE;
-    qapi_event_send_block_io_error(bdrv_get_device_name(bs), ac, action,
+    op = is_read ? IO_OPERATION_TYPE_READ : IO_OPERATION_TYPE_WRITE;
+    qapi_event_send_block_io_error(bdrv_get_device_name(bs), op, action,
                                    bdrv_iostatus_is_enabled(bs),
                                    error == ENOSPC, strerror(error),
                                    &error_abort);
-- 
1.9.3 (Apple Git-50)

Re: [Qemu-devel] [PATCH] block: fix implicit convertion to invalid type

[Max Reitz]

Am 16.10.2014 um 14:10 schrieb Igor Mammedov:
> change type of variable to expected IoOperationType which fixes compile
> warning:
>
> block.c:3655:20: warning: implicit conversion from enumeration
>   type enum IoOperationType to different enumeration type BlockErrorAction
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>   block.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>

Re: [Qemu-devel] [PATCH] block: fix implicit convertion to invalid type

[Max Reitz]

Am 16.10.2014 um 15:34 schrieb Max Reitz:
> Am 16.10.2014 um 14:10 schrieb Igor Mammedov:
>> change type of variable to expected IoOperationType which fixes compile
>> warning:
>>
>> block.c:3655:20: warning: implicit conversion from enumeration
>>   type enum IoOperationType to different enumeration type 
>> BlockErrorAction
>>
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>> ---
>>   block.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> Reviewed-by: Max Reitz <mreitz@redhat.com>

Oh, I had the feeling I was forgetting something. The subject should 
read "conversion", not "convertion". Feel free to keep my R-b if you 
send a v2 to fix it.

Max

Re: [Qemu-devel] [PATCH] block: fix implicit convertion to invalid type

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

On Thu, Oct 16, 2014 at 02:10:06PM +0200, Igor Mammedov wrote:
> change type of variable to expected IoOperationType which fixes compile
> warning:
> 
> block.c:3655:20: warning: implicit conversion from enumeration
>  type enum IoOperationType to different enumeration type BlockErrorAction
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  block.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Thanks Igor.  Peter Maydell already sent a fix "block.c: Fix type of
IoOperationType variable in send_qmp_error_event()".

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]