From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XelH5-0000wR-OZ for qemu-devel@nongnu.org; Thu, 16 Oct 2014 09:39:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XelGv-0006QZ-Fa for qemu-devel@nongnu.org; Thu, 16 Oct 2014 09:39:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XelGv-0006QU-8A for qemu-devel@nongnu.org; Thu, 16 Oct 2014 09:39:17 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9GDdGGc013224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 16 Oct 2014 09:39:16 -0400 Message-ID: <543FCA81.7060703@redhat.com> Date: Thu, 16 Oct 2014 15:39:13 +0200 From: Max Reitz MIME-Version: 1.0 References: <1413461406-59379-1-git-send-email-imammedo@redhat.com> <543FC94A.4040409@redhat.com> In-Reply-To: <543FC94A.4040409@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: fix implicit convertion to invalid type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com Am 16.10.2014 um 15:34 schrieb Max Reitz: > Am 16.10.2014 um 14:10 schrieb Igor Mammedov: >> change type of variable to expected IoOperationType which fixes compile >> warning: >> >> block.c:3655:20: warning: implicit conversion from enumeration >> type enum IoOperationType to different enumeration type >> BlockErrorAction >> >> Signed-off-by: Igor Mammedov >> --- >> block.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > > Reviewed-by: Max Reitz Oh, I had the feeling I was forgetting something. The subject should read "conversion", not "convertion". Feel free to keep my R-b if you send a v2 to fix it. Max