[Qemu-devel] [PATCH] util: Improve os_mem_prealloc error message

[Qemu-devel] [PATCH] util: Improve os_mem_prealloc error message

[Michal Privoznik]

Currently, when the preallocating guest memory process fails, an not
so helpful error message is printed out:

    # virsh start migt10
    error: Failed to start domain migt10
    error: internal error: process exited while connecting to monitor:
    os_mem_prealloc: failed to preallocate pages

>From the error message it's not clear at the first glance where the
problem lies. However, changing the error message might give uses a
clue.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 util/oslib-posix.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index 016a047..8c9d80e 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -390,7 +390,8 @@ void os_mem_prealloc(int fd, char *area, size_t memory)
     pthread_sigmask(SIG_UNBLOCK, &set, &oldset);
 
     if (sigsetjmp(sigjump, 1)) {
-        fprintf(stderr, "os_mem_prealloc: failed to preallocate pages\n");
+        fprintf(stderr, "os_mem_prealloc: Insufficient free host memory "
+                        "pages available to allocate guest RAM\n");
         exit(1);
     } else {
         int i;
-- 
2.0.4

Re: [Qemu-devel] [PATCH] util: Improve os_mem_prealloc error message

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1477 bytes --]

On 10/16/2014 07:13 AM, Michal Privoznik wrote:
> Currently, when the preallocating guest memory process fails, an not

s/an/a/

> so helpful error message is printed out:
> 
>     # virsh start migt10
>     error: Failed to start domain migt10
>     error: internal error: process exited while connecting to monitor:
>     os_mem_prealloc: failed to preallocate pages
> 
>>From the error message it's not clear at the first glance where the
> problem lies. However, changing the error message might give uses a

s/uses/users/

> clue.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  util/oslib-posix.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 016a047..8c9d80e 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -390,7 +390,8 @@ void os_mem_prealloc(int fd, char *area, size_t memory)
>      pthread_sigmask(SIG_UNBLOCK, &set, &oldset);
>  
>      if (sigsetjmp(sigjump, 1)) {
> -        fprintf(stderr, "os_mem_prealloc: failed to preallocate pages\n");
> +        fprintf(stderr, "os_mem_prealloc: Insufficient free host memory "
> +                        "pages available to allocate guest RAM\n");
>          exit(1);
>      } else {
>          int i;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]

Re: [Qemu-devel] [Qemu-trivial] [PATCH] util: Improve os_mem_prealloc error message

[Michael Tokarev]

On 10/16/2014 05:13 PM, Michal Privoznik wrote:
> Currently, when the preallocating guest memory process fails, an not
> so helpful error message is printed out:
[..]

Applied to -trivial finally, with small commit message corrections
from Eric.  Thanks!

/mjt