From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XemQE-0003zX-HT for qemu-devel@nongnu.org; Thu, 16 Oct 2014 10:53:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XemQ9-00069F-Jp for qemu-devel@nongnu.org; Thu, 16 Oct 2014 10:52:58 -0400 Message-ID: <543FDBB6.1070204@redhat.com> Date: Thu, 16 Oct 2014 08:52:38 -0600 From: Eric Blake MIME-Version: 1.0 References: <26626bbd0b1652d964c39937c378bb53089260f6.1413465100.git.mprivozn@redhat.com> In-Reply-To: <26626bbd0b1652d964c39937c378bb53089260f6.1413465100.git.mprivozn@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LbCkLfHUAJoMIQJ7nwURvew0F7qx365aS" Subject: Re: [Qemu-devel] [PATCH] util: Improve os_mem_prealloc error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Privoznik , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, kwolf@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LbCkLfHUAJoMIQJ7nwURvew0F7qx365aS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/16/2014 07:13 AM, Michal Privoznik wrote: > Currently, when the preallocating guest memory process fails, an not s/an/a/ > so helpful error message is printed out: >=20 > # virsh start migt10 > error: Failed to start domain migt10 > error: internal error: process exited while connecting to monitor: > os_mem_prealloc: failed to preallocate pages >=20 >>>From the error message it's not clear at the first glance where the > problem lies. However, changing the error message might give uses a s/uses/users/ > clue. >=20 > Signed-off-by: Michal Privoznik > --- > util/oslib-posix.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 Reviewed-by: Eric Blake > diff --git a/util/oslib-posix.c b/util/oslib-posix.c > index 016a047..8c9d80e 100644 > --- a/util/oslib-posix.c > +++ b/util/oslib-posix.c > @@ -390,7 +390,8 @@ void os_mem_prealloc(int fd, char *area, size_t mem= ory) > pthread_sigmask(SIG_UNBLOCK, &set, &oldset); > =20 > if (sigsetjmp(sigjump, 1)) { > - fprintf(stderr, "os_mem_prealloc: failed to preallocate pages\= n"); > + fprintf(stderr, "os_mem_prealloc: Insufficient free host memor= y " > + "pages available to allocate guest RAM\n"); > exit(1); > } else { > int i; >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LbCkLfHUAJoMIQJ7nwURvew0F7qx365aS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUP9u2AAoJEKeha0olJ0NqUpQH/A8R2rXPE6tXyRefIpojFzlf z9aBSgSQRkaft/z1I4zCD4IG1ITLpO8cvvGJ+udhKJ9yNQPqut+JUI8MRPx60Uu2 DLLUqKjnVK8CZjdWQBOOaziJdcKuNG+JOrPsdF9kuLhHxqLMloAU6gGOckgdD7Yx DacSyMUamBKC8YAUeqZ60aMDUk0cEqDSXLaI8TZMMGHr2RsZWkJG7mb4mI8EM2zq YfUyop8leydaiLUyvoP86PTc2Ab4jCi39dGVPsKQ2ZIfczd24HLi/qwMtvEBNYS7 7nyjs9tyC2LjtY/Ay5pmaLKIolxIFVmM3C+1NKFSaxWyDmkpVSi8YnkBO/emg30= =fLWW -----END PGP SIGNATURE----- --LbCkLfHUAJoMIQJ7nwURvew0F7qx365aS--