From: Marek Glogowski <smarkusg@gmail.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v6] ui/cocoa: Use NSWindow's ability to resize
Date: Sat, 16 Dec 2023 23:40:54 +0100 [thread overview]
Message-ID: <544280AF-A12F-4D4A-ABBB-150D396C7694@gmail.com> (raw)
In-Reply-To: <CADfA340BGjC7vvWfx9xRL=MPpZHLkWX8=3y2uqSiD9EWdZpbzw@mail.gmail.com>
Hi
I think I may have found a small error
> if (opts->u.cocoa.has_zoom_to_fit && opts->u.cocoa.zoom_to_fit) {
+ [normalWindow setStyleMask:[normalWindow styleMask] & ~NSWindowStyleMaskResizable];
it should probably be so, because the window never goes into a good mode
[normalWindow setStyleMask:[normalWindow styleMask] | NSWindowStyleMaskResizable];
and the zoom to fit option will never be checked end enable
menuItem = [[[NSMenuItem alloc] initWithTitle:@"Zoom To Fit" action:@selector(zoomToFit:) keyEquivalent:@""] autorelease];
[menuItem setState: [normalWindow styleMask] & NSWindowStyleMaskResizable ? NSControlStateValueOn : NSControlStateValueOff];
next prev parent reply other threads:[~2023-12-16 22:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 5:39 [PATCH v6] ui/cocoa: Use NSWindow's ability to resize Akihiko Odaki
2023-12-12 8:04 ` Marek Glogowski
2023-12-12 8:28 ` Akihiko Odaki
2023-12-12 8:43 ` Marek Glogowski
2023-12-16 22:40 ` Marek Glogowski [this message]
[not found] ` <5fcbed94a573a1b3bc9968ef9f72b496@mail.emailn.de>
2023-12-13 5:53 ` Akihiko Odaki
2023-12-13 17:22 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544280AF-A12F-4D4A-ABBB-150D396C7694@gmail.com \
--to=smarkusg@gmail.com \
--cc=akihiko.odaki@daynix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).