From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52687)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1Xg6Ps-0000JM-4H
	for qemu-devel@nongnu.org; Mon, 20 Oct 2014 02:26:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1Xg6Pl-0000Sh-P8
	for qemu-devel@nongnu.org; Mon, 20 Oct 2014 02:26:04 -0400
Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:59996 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1Xg6Pl-0000SV-FB
	for qemu-devel@nongnu.org; Mon, 20 Oct 2014 02:25:57 -0400
Message-ID: <5444AAF1.7040505@kamp.de>
Date: Mon, 20 Oct 2014 08:25:53 +0200
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1413465957-20865-1-git-send-email-mreitz@redhat.com>
	<1413465957-20865-3-git-send-email-mreitz@redhat.com>
In-Reply-To: <1413465957-20865-3-git-send-email-mreitz@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] iotests: Add test for qcow2 L1 table
	update
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 16.10.2014 15:25, Max Reitz wrote:
> Updating the L1 table should not result in random data being written.
> This adds a test for that.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>   tests/qemu-iotests/107     | 61 ++++++++++++++++++++++++++++++++++++++++++++++
>   tests/qemu-iotests/107.out | 10 ++++++++
>   tests/qemu-iotests/group   |  1 +
>   3 files changed, 72 insertions(+)
>   create mode 100755 tests/qemu-iotests/107
>   create mode 100644 tests/qemu-iotests/107.out
>
> diff --git a/tests/qemu-iotests/107 b/tests/qemu-iotests/107
> new file mode 100755
> index 0000000..cad1cf9
> --- /dev/null
> +++ b/tests/qemu-iotests/107
> @@ -0,0 +1,61 @@
> +#!/bin/bash
> +#
> +# Tests updates of the qcow2 L1 table
> +#
> +# Copyright (C) 2014 Red Hat, Inc.
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +#
> +
> +# creator
> +owner=mreitz@redhat.com
> +
> +seq="$(basename $0)"
> +echo "QA output created by $seq"
> +
> +here="$PWD"
> +tmp=/tmp/$$
> +status=1	# failure is the default!
> +
> +_cleanup()
> +{
> +	_cleanup_test_img
> +}
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +# get standard environment, filters and checks
> +. ./common.rc
> +. ./common.filter
> +
> +_supported_fmt qcow2
> +_supported_proto file

This (and maybe other recently added tests) also works on NFS.
As NFS on QCOW2 might be a reasonable combination I would add it.

Peter