Re: [Qemu-devel] [PATCH 2/2] iotests: Add test for qcow2 L1 table update

[Max Reitz <mreitz@redhat.com>]

On 2014-10-20 at 08:25, Peter Lieven wrote:
> On 16.10.2014 15:25, Max Reitz wrote:
>> Updating the L1 table should not result in random data being written.
>> This adds a test for that.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   tests/qemu-iotests/107     | 61 
>> ++++++++++++++++++++++++++++++++++++++++++++++
>>   tests/qemu-iotests/107.out | 10 ++++++++
>>   tests/qemu-iotests/group   |  1 +
>>   3 files changed, 72 insertions(+)
>>   create mode 100755 tests/qemu-iotests/107
>>   create mode 100644 tests/qemu-iotests/107.out
>>
>> diff --git a/tests/qemu-iotests/107 b/tests/qemu-iotests/107
>> new file mode 100755
>> index 0000000..cad1cf9
>> --- /dev/null
>> +++ b/tests/qemu-iotests/107
>> @@ -0,0 +1,61 @@
>> +#!/bin/bash
>> +#
>> +# Tests updates of the qcow2 L1 table
>> +#
>> +# Copyright (C) 2014 Red Hat, Inc.
>> +#
>> +# This program is free software; you can redistribute it and/or modify
>> +# it under the terms of the GNU General Public License as published by
>> +# the Free Software Foundation; either version 2 of the License, or
>> +# (at your option) any later version.
>> +#
>> +# This program is distributed in the hope that it will be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +# GNU General Public License for more details.
>> +#
>> +# You should have received a copy of the GNU General Public License
>> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
>> +#
>> +
>> +# creator
>> +owner=mreitz@redhat.com
>> +
>> +seq="$(basename $0)"
>> +echo "QA output created by $seq"
>> +
>> +here="$PWD"
>> +tmp=/tmp/$$
>> +status=1    # failure is the default!
>> +
>> +_cleanup()
>> +{
>> +    _cleanup_test_img
>> +}
>> +trap "_cleanup; exit \$status" 0 1 2 3 15
>> +
>> +# get standard environment, filters and checks
>> +. ./common.rc
>> +. ./common.filter
>> +
>> +_supported_fmt qcow2
>> +_supported_proto file
>
> This (and maybe other recently added tests) also works on NFS.
> As NFS on QCOW2 might be a reasonable combination I would add it.

It probably works over some other protocols as well. I think we want to 
go through all the tests in a separate series and fix all of these 
cases. I'll fix it in a v2 if I need to do a v2, if not, I'll leave it 
as-is. If you want to test qcow2, you want to run all tests over file, 
probably. If you want to test nfs, you probably don't want to use qcow2 
but raw (because many of the currently existing tests are too limited in 
their format and protocol choices).

Since you suggested looking into which tests actually support more 
formats and protocols than they currently pretend to, feel free to send 
such a series. ;-)

Max